[GitHub] [beam] TheNeuralBit commented on a diff in pull request #21965: Update documentations and document generation

[GitBox <gi...@apache.org>]

TheNeuralBit commented on code in PR #21965:
URL: https://github.com/apache/beam/pull/21965#discussion_r902918214


##########
sdks/python/apache_beam/ml/inference/base.py:
##########
@@ -67,6 +67,11 @@
         ('example', _INPUT_TYPE),
         ('inference', _OUTPUT_TYPE),
     ])
+PredictionResult.__doc__ = """A NamedTuple containing both input and output
+  from the inference."""
+PredictionResult.example.__doc__ = """The input example."""
+PredictionResult.inference.__doc__ = """Results for the inference on the model
+  for the given example."""

Review Comment:
   I guess I missed this. Why aren't we using the class form of NamedTuple? Is it because the type variables/generics don't work?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org