You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2026/02/16 04:56:11 UTC
[PR] [SPARK-55543] Change `SentinelManager.getSentinelResources` to `package private` [spark-kubernetes-operator]
dongjoon-hyun opened a new pull request, #502:
URL: https://github.com/apache/spark-kubernetes-operator/pull/502
### What changes were proposed in this pull request?
This PR aims to change `SentinelManager.getSentinelResources` to `package private` from `public`.
### Why are the changes needed?
This was designed to be `public` and marked as `VisibleForTesting`. However, `SentinelManagerTest` can test it as `package private`. So, we don't need to expose this as a `public` method.
### Does this PR introduce _any_ user-facing change?
No. This is supposed to be used internally by `Apache Spark K8s Operator`.
### How was this patch tested?
Pass the CIs.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: `Gemini 3 Pro (High)` on `Antigravity`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55543] Change `SentinelManager.getSentinelResources` to `package private` [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #502: [SPARK-55543] Change `SentinelManager.getSentinelResources` to `package private`
URL: https://github.com/apache/spark-kubernetes-operator/pull/502
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55543] Change `SentinelManager.getSentinelResources` to `package private` [spark-kubernetes-operator]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #502:
URL: https://github.com/apache/spark-kubernetes-operator/pull/502#issuecomment-3906492041
Thank you, @viirya ~ Merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org