[GitHub] [storm] srdo commented on issue #2974: STORM-3355: Use supervisor.worker.shutdown.sleep.secs to set worker s…

[GitBox <gi...@apache.org>]

srdo commented on issue #2974: STORM-3355: Use supervisor.worker.shutdown.sleep.secs to set worker s…
URL: https://github.com/apache/storm/pull/2974#issuecomment-473407945
 
 
   I'm not sure it's an issue that it's non-deterministic. The force kill only happens if the worker fails to shut down within the time limit, which should hopefully be rare. If the time limit is hit, does it matter whether the supervisor `kill -9`'s the worker JVM, or whether the worker JVM suicides?
   
   I assumed the reason we want the worker to suicide is in case the supervisor issues a soft kill, and then crashes. I'm not sure how the supervisor handles it if it is restarted and the worker is a "zombie" hanging in the middle of shutdown?
   
   If that's not the reason, I'm not sure. Relying on the supervisor's kill might be fine?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services