[GitHub] [samza] b-slim commented on a change in pull request #1401: SAMZA-2560: Generate SamzaSQLRelRecord using avro schema of input event instead of cached-schema.

[GitBox <gi...@apache.org>]

b-slim commented on a change in pull request #1401:
URL: https://github.com/apache/samza/pull/1401#discussion_r456529822



##########
File path: samza-sql/src/main/java/org/apache/samza/sql/avro/AvroRelConverter.java
##########
@@ -125,11 +125,18 @@ public static void fetchFieldNamesAndValuesFromIndexedRecord(IndexedRecord recor
         .collect(Collectors.toList()));
   }
 
-  private static SamzaSqlRelRecord convertToRelRecord(IndexedRecord avroRecord, Schema schema) {
+  private static SamzaSqlRelRecord convertToRelRecord(IndexedRecord avroRecord) {
     List<Object> fieldValues = new ArrayList<>();
     List<String> fieldNames = new ArrayList<>();
     if (avroRecord != null) {
-      fetchFieldNamesAndValuesFromIndexedRecord(avroRecord, fieldNames, fieldValues, schema);
+      fieldNames.addAll(

Review comment:
       Can we add a simple unit test or at least a comment to avoid that this happens again in the future ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org