[GitHub] [sling-org-apache-sling-discovery-oak] mreutegg commented on pull request #7: SLING-11450 : avoid suppressing instances that were seen previously

[GitBox <gi...@apache.org>]

mreutegg commented on PR #7:
URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/7#issuecomment-1185597688

   I can reproduce those test failures reported by Jenkins and did some debugging to find out why they fail. I may not have an in-depth understanding of the implementation, but one area that looks weird to me is how IdMapService reads the idMap.
   
   E.g. when I debug PartialStartupTest.testNoLocalSyncTokenYet(), then I can see that at some point IdMapService.readIdMap() reads 4 id to slingId mappings from /var/discovery/oak/idMap. However, the returned Map only contains 3 entries, because on the node in the repository there are two slingId properties that point to the same id.
   
   - 289b8024-1437-4f5a-984c-97d01f5a5456 -> 2
   - 0384e415-bd6f-477b-b32d-4387b06330ee -> 1
   - 3fce3eb8-3a7e-423a-b662-f1880cb75e49 -> 3
   - 226d18c3-d979-42c6-ab1a-f1c641dd8c31 -> 3
   
   Doesn't this cause problems later? It appears this can randomly hide some mapping.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org