You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2023/12/20 17:52:47 UTC

(superset) branch master updated: fix(sql lab): Use quote_schema instead of quote method to format schema name (#26281)

This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 9d3796828c fix(sql lab): Use quote_schema instead of quote method to format schema name (#26281)
9d3796828c is described below

commit 9d3796828c102b5a93d2ad936d493820a9828f9d
Author: Guen Prawiroatmodjo <gu...@gmail.com>
AuthorDate: Wed Dec 20 12:52:39 2023 -0500

    fix(sql lab): Use quote_schema instead of quote method to format schema name (#26281)
---
 superset/db_engine_specs/base.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset/db_engine_specs/base.py b/superset/db_engine_specs/base.py
index 9894232ab1..6bc8c444d6 100644
--- a/superset/db_engine_specs/base.py
+++ b/superset/db_engine_specs/base.py
@@ -1433,8 +1433,9 @@ class BaseEngineSpec:  # pylint: disable=too-many-public-methods
         if show_cols:
             fields = cls._get_fields(cols)
         quote = engine.dialect.identifier_preparer.quote
+        quote_schema = engine.dialect.identifier_preparer.quote_schema
         if schema:
-            full_table_name = quote(schema) + "." + quote(table_name)
+            full_table_name = quote_schema(schema) + "." + quote(table_name)
         else:
             full_table_name = quote(table_name)