You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/27 17:28:52 UTC

[GitHub] [airflow] cb149 opened a new issue, #17469: Label infront of TaskGroup breaks task dependencies

cb149 opened a new issue, #17469:
URL: https://github.com/apache/airflow/issues/17469

   **Apache Airflow version**: 2.1.0
   
   **What happened**:
   
   Using a Label infront of a TaskGroup breaks task dependencies, as tasks before the TaskGroup will now point to the last task in the TaskGroup.
   
   **What you expected to happen**:
   
   Task dependencies with or without Labels should be the same (and preferably the Label should be visible outside of the TaskGroup).
   Behavior without a Label is as follows:
   
   ```python
   with TaskGroup("tg1", tooltip="Tasks related to task group") as tg1:
           DummyOperator(task_id="b") >> DummyOperator(task_id="c")
   
   DummyOperator(task_id="a") >> tg1
   ```
   ![without Taskgroup](https://user-images.githubusercontent.com/35238779/128502690-58b31577-91d7-4b5c-b348-4779c9286958.png)
   
   **How to reproduce it**:
   
   ```python
   with TaskGroup("tg1", tooltip="Tasks related to task group") as tg1:
           DummyOperator(task_id="b") >> DummyOperator(task_id="c")
   
       DummyOperator(task_id="a") >> Label("testlabel") >> tg1
   ```
   ![with TaskGroup](https://user-images.githubusercontent.com/35238779/128502758-5252b7e7-7c30-424a-ac3a-3f9a99b0a805.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed issue #17469: Label in front of TaskGroup breaks task dependencies

Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #17469: Label in front of TaskGroup breaks task dependencies
URL: https://github.com/apache/airflow/issues/17469


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #17469: Label in front of TaskGroup breaks task dependencies

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #17469:
URL: https://github.com/apache/airflow/issues/17469#issuecomment-1236078062

   Issue status:
   A PR was raised to fix the issue https://github.com/apache/airflow/pull/21404 but was reverted due to regression.
   A unit test was added to catch the missed case in https://github.com/apache/airflow/pull/23300
   
   If anyone wants to pick it up feel free to comment
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on issue #17469: Label infront of TaskGroup breaks task dependencies

Posted by GitBox <gi...@apache.org>.
ashb commented on issue #17469:
URL: https://github.com/apache/airflow/issues/17469#issuecomment-1111287257

   We are having to revert the PR that fixes this, so re-opening this issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #17469: Label in front of TaskGroup breaks task dependencies

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #17469:
URL: https://github.com/apache/airflow/issues/17469#issuecomment-1117012889

   @avkirilishin would you redo the PR ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org