[jira] [Commented] (TEZ-989) Allow addition of resources to the AM for a running session

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13951447#comment-13951447 ] 

Hitesh Shah commented on TEZ-989:
---------------------------------

bq. if (additionalAmResources != null) 
   - additionalAmResources != null && !additionalAmResources.isEmpty()

{code}
         DagTypeConverters.convertFromLocalResources(sessionJars);
       sessionJarsPBOutStream = FileSystem.create(fs, sessionJarsPath,
         new FsPermission(TEZ_AM_FILE_PERMISSION));
-      proto.writeTo(sessionJarsPBOutStream);
+      proto.writeDelimitedTo(sessionJarsPBOutStream);
+      
+      // Write out the initial list of resources which will be available in the AM
+      DAGProtos.PlanLocalResourcesProto initialAMResourceProto = DagTypeConverters
+          .convertFromLocalResources(localResources);
+      initialAMResourceProto.writeDelimitedTo(sessionJarsPBOutStream);
{code}
   - any reason we need delimited records? Why not just combine the collection before serializing? 

Mostly looks good. 



> Allow addition of resources to the AM for a running session
> -----------------------------------------------------------
>
>                 Key: TEZ-989
>                 URL: https://issues.apache.org/jira/browse/TEZ-989
>             Project: Apache Tez
>          Issue Type: Improvement
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>         Attachments: TEZ-989.1.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)