You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/04/02 06:53:33 UTC
[GitHub] [pulsar] hangc0276 opened a new pull request #10126: remove unnessary bundle listener triger when topic lookup
hangc0276 opened a new pull request #10126:
URL: https://github.com/apache/pulsar/pull/10126
### Motivation
When call `resolveOwnership`, it will trigger listener notify, and the registered listeners will trigger onLoad/unLoad operation. However, the `resolveOwnership` will be called by topic lookup check, thus the registered listeners will be notified on each lookup check. In fact, the listeners only need to be notified when bundle load/unload.
### Changes
1. remove listeners' trigger notify operation on `resolveOwnership`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #10126: remove unnessary bundle listener triger when topic lookup
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10126:
URL: https://github.com/apache/pulsar/pull/10126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on pull request #10126: remove unnessary bundle listener triger when topic lookup
Posted by GitBox <gi...@apache.org>.
jiazhai commented on pull request #10126:
URL: https://github.com/apache/pulsar/pull/10126#issuecomment-813943390
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] kezhuw commented on a change in pull request #10126: remove unnessary bundle listener triger when topic lookup
Posted by GitBox <gi...@apache.org>.
kezhuw commented on a change in pull request #10126:
URL: https://github.com/apache/pulsar/pull/10126#discussion_r606666539
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceOwnershipListenerTests.java
##########
@@ -124,4 +125,53 @@ public void testGetAllPartitions() throws PulsarAdminException, ExecutionExcepti
admin.namespaces().deleteNamespace(namespace);
}
+ @Test
+ public void testNamespaceBundleLookupOnwershipListener() throws PulsarAdminException, InterruptedException,
Review comment:
Typo, should be`Ownership`.
##########
File path: pulsar-broker/src/test/java/org/apache/pulsar/broker/namespace/NamespaceOwnershipListenerTests.java
##########
@@ -124,4 +125,53 @@ public void testGetAllPartitions() throws PulsarAdminException, ExecutionExcepti
admin.namespaces().deleteNamespace(namespace);
}
+ @Test
+ public void testNamespaceBundleLookupOnwershipListener() throws PulsarAdminException, InterruptedException,
Review comment:
The test does not fail either without changes applied.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] hangc0276 commented on pull request #10126: remove unnessary bundle listener triger when topic lookup
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on pull request #10126:
URL: https://github.com/apache/pulsar/pull/10126#issuecomment-812399466
@kezhuw Would you please help review the code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org