[GitHub] [hadoop] ferhui edited a comment on pull request #2416: HDFS-15652. Make block size from NNThroughputBenchmark configurable

[GitBox <gi...@apache.org>]

ferhui edited a comment on pull request #2416:
URL: https://github.com/apache/hadoop/pull/2416#issuecomment-716935416


   > Hi thanks for the patch. It would be the best if you can make the block size configurable from command argument as well. The replication factor is configurable through config as well as arguments.
   
   OK. @jojochuang Thanks for review !
   
   There is a checkstyle problem
   
   > ./hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java:172:    protected int blockSize;:19: Variable 'blockSize' must be private and have accessor methods. [VisibilityModifier]
   
   I keep the style the same as original code. If fix this, It's different from other code, looks strange. How to deal with it ?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org