Re: [PR] fix(loki-logger): prevent log_labels cross-request leakage [apisix]

["Adarsh879 (via GitHub)" <gi...@apache.org>]

Adarsh879 commented on PR #13326:
URL: https://github.com/apache/apisix/pull/13326#issuecomment-4602774919

   Thanks for the review! Added in 9e79f92e35c3d43fddf02c4f89af09ae5f7387de.
   
   `TEST 20–22` now covers the batch grouping path:
   
   - Route configured with `log_labels: { batch_label: "$arg_X" }` and **`batch_max_size: 2`**
   - Sends `/hello?X=gamma` then `/hello?X=delta` so both entries land in the **same batch flush**
   - Asserts Loki ends up with **two distinct streams** (`batch_label="gamma"` and `batch_label="delta"`)
   
   I verified it both ways locally (Loki 2.8 + `-auth.enabled`, matching CI):
   
   - **With the fix:** all subtests pass
   - **Reverting just the plugin change:** `TEST 22` fails — the buggy code produces a single frozen `gamma` stream holding both entries


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org