[GitHub] [dolphinscheduler] baisui1981 commented on a change in pull request #7226: [ISSUE 6444]Optimize task node helper document in workflow toolbar

[GitBox <gi...@apache.org>]

baisui1981 commented on a change in pull request #7226:
URL: https://github.com/apache/dolphinscheduler/pull/7226#discussion_r763594310



##########
File path: dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue
##########
@@ -550,7 +554,18 @@
         backfillRefresh: true,
         // whether this is a new Task
         isNewCreate: true,
-        tasksTypeList: Object.keys(tasksType)
+        tasksTypeList: Object.keys(tasksType),
+        helpUrlEnable: function (typeKey) {
+          let type = tasksType[typeKey]
+          if (type) {
+            let disabled = !!type.helperLinkDisable
+            return !disabled
+          }
+          return false

Review comment:
       ok , has been modified
   ``` javascript
   helpUrlEnable: function (typeKey) {
             const type = tasksType[typeKey]
             if (type) {
               if (!type.helperLinkDisable) return true
               return !type.helperLinkDisable
             }
             return false
           },
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org