[GitHub] [pulsar] Jason918 commented on a diff in pull request #15628: Fix delay messages are expired by TTL policy

[GitBox <gi...@apache.org>]

Jason918 commented on code in PR #15628:
URL: https://github.com/apache/pulsar/pull/15628#discussion_r1003931565


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentMessageExpiryMonitor.java:
##########
@@ -77,8 +77,10 @@ public boolean expireMessages(int messageTTLInSeconds) {
 
             cursor.asyncFindNewestMatching(ManagedCursor.FindPositionConstraint.SearchActiveEntries, entry -> {
                 try {
-                    long entryTimestamp = Commands.getEntryTimestamp(entry.getDataBuffer());
-                    return MessageImpl.isEntryExpired(messageTTLInSeconds, entryTimestamp);
+                    // When the time of the delayed message is greater than the time specified by TTL, we should
+                    // give up checking the TTL of the current delayed message, because the time of the delayed
+                    // message has not yet arrived, we cannot delete these messages.
+                    return MessageImpl.isEntryExpired(messageTTLInSeconds, entry.getDataBuffer());

Review Comment:
   It's a binary search process. If we return a result depending on a non monotone increasing field(delayTime), the search result normally will go wild. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org