You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/05 10:24:57 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
eolivelli opened a new pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485
### Motivation
Some command use the old format "property/cluster/namespace", it is better that the help reflects current version style.
### Modifications
Fix the examples
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#issuecomment-836249054
@merlimat I apologise for the confusion.
Now the patch is in good shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#issuecomment-967301216
@eolivelli:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#discussion_r628518255
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNonPersistentTopics.java
##########
@@ -122,7 +122,7 @@ void run() throws Exception {
@Parameters(commandDescription = "Get list of non-persistent topics present under a namespace")
private class GetList extends CliCommand {
- @Parameter(description = "property/cluster/namespace", required = true)
+ @Parameter(description = "tenant/namespaces", required = true)
Review comment:
Where there was the "namespace" only parts is still written in plural form
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#issuecomment-836852553
an integration test fails consistently. I have to check it out.
moving status to "draft"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#issuecomment-897568305
@merlimat precommit check passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli closed pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#discussion_r628517197
##########
File path: bouncy-castle/bc/pom.xml
##########
@@ -25,7 +25,7 @@
<parent>
<groupId>org.apache.pulsar</groupId>
<artifactId>bouncy-castle-parent</artifactId>
- <version>2.8.0-SNAPSHOT</version>
+ <version>2.7.2.1.0.0</version>
Review comment:
Ok, now there was some merge issue :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat commented on a change in pull request #10485: Update command descriptions from old 'property/cluster/namespace' format to current 'tenant/namespace' format
Posted by GitBox <gi...@apache.org>.
merlimat commented on a change in pull request #10485:
URL: https://github.com/apache/pulsar/pull/10485#discussion_r627820123
##########
File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNonPersistentTopics.java
##########
@@ -53,7 +53,7 @@ private NonPersistentTopics getNonPersistentTopics() {
@Parameters(commandDescription = "Lookup a topic from the current serving broker")
private class Lookup extends CliCommand {
- @Parameter(description = "non-persistent://property/cluster/namespace/topic", required = true)
+ @Parameter(description = "non-persistent://tenant/namespaces/topic", required = true)
Review comment:
In all the repetitions, it should be:
```suggestion
@Parameter(description = "non-persistent://tenant/namespace/topic", required = true)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org