You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/02 21:17:00 UTC

[jira] [Work logged] (BEAM-8645) TimestampCombiner incorrect in beam python

     [ https://issues.apache.org/jira/browse/BEAM-8645?focusedWorklogId=352213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-352213 ]

ASF GitHub Bot logged work on BEAM-8645:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Dec/19 21:16
            Start Date: 02/Dec/19 21:16
    Worklog Time Spent: 10m 
      Work Description: HuangLED commented on issue #10081: [BEAM-8645] A test case for TimestampCombiner.
URL: https://github.com/apache/beam/pull/10081#issuecomment-560584323
 
 
   @robertwb  ping for merging this PR
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 352213)
    Time Spent: 8.5h  (was: 8h 20m)

> TimestampCombiner incorrect in beam python
> ------------------------------------------
>
>                 Key: BEAM-8645
>                 URL: https://issues.apache.org/jira/browse/BEAM-8645
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Ruoyun Huang
>            Priority: Major
>          Time Spent: 8.5h
>  Remaining Estimate: 0h
>
> When we have a TimestampValue on combine: 
> {code:java}
> main_stream = (p                   
> | 'main TestStream' >> TestStream()                   .add_elements([window.TimestampedValue(('k', 100), 0)])                   .add_elements([window.TimestampedValue(('k', 400), 9)])                   .advance_watermark_to_infinity()                   
> | 'main windowInto' >> beam.WindowInto(                         window.FixedWindows(10),                      timestamp_combiner=TimestampCombiner.OUTPUT_AT_LATEST)                   | 'Combine' >> beam.CombinePerKey(sum))
> The expect timestamp should be:
> LATEST:    (('k', 500), Timestamp(9)),
> EARLIEST:    (('k', 500), Timestamp(0)),
> END_OF_WINDOW: (('k', 500), Timestamp(10)),
> But current py streaming gives following results: 
> LATEST:    (('k', 500), Timestamp(10)),
> EARLIEST:    (('k', 500), Timestamp(10)),
> END_OF_WINDOW: (('k', 500), Timestamp(9.99999999)),
> More details and discussions:
> https://lists.apache.org/thread.html/d3af1f2f84a2e59a747196039eae77812b78a991f0f293c717e5f4e1@%3Cdev.beam.apache.org%3E
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)