You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jojy Varghese <jo...@mesosphere.io> on 2015/06/17 02:13:08 UTC
Review Request 35544: containerizer: statically initialize isolator
factories
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/
-----------------------------------------------------------
Review request for mesos and Timothy Chen.
Repository: mesos
Description
-------
Replaced dynamic hashmap creation with c++11's static initialization.
Diffs
-----
src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
Diff: https://reviews.apache.org/r/35544/diff/
Testing
-------
make check
Thanks,
Jojy Varghese
Re: Review Request 35544: containerizer: statically initialize
isolator factories
Posted by Till Toenshoff <to...@me.com>.
> On June 17, 2015, 9:38 a.m., Till Toenshoff wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 135
> > <https://reviews.apache.org/r/35544/diff/1/?file=986152#file986152line135>
> >
> > Why is this change needed?
>
> Jojy Varghese wrote:
> the operator[] is not constant. So we cant use it for constant objects.
Hah, good point - thanks for the answer :)
- Till
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88203
-----------------------------------------------------------
On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 12:13 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced dynamic hashmap creation with c++11's static initialization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
>
> Diff: https://reviews.apache.org/r/35544/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 35544: containerizer: statically initialize
isolator factories
Posted by Jojy Varghese <jo...@mesosphere.io>.
> On June 17, 2015, 9:38 a.m., Till Toenshoff wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 135
> > <https://reviews.apache.org/r/35544/diff/1/?file=986152#file986152line135>
> >
> > Why is this change needed?
the operator[] is not constant. So we cant use it for constant objects.
- Jojy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88203
-----------------------------------------------------------
On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 12:13 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced dynamic hashmap creation with c++11's static initialization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
>
> Diff: https://reviews.apache.org/r/35544/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 35544: containerizer: statically initialize
isolator factories
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88203
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/containerizer.cpp (line 134)
<https://reviews.apache.org/r/35544/#comment140596>
Why is this change needed?
- Till Toenshoff
On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 12:13 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced dynamic hashmap creation with c++11's static initialization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
>
> Diff: https://reviews.apache.org/r/35544/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 35544: containerizer: statically initialize
isolator factories
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88191
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35544]
All tests passed.
- Mesos ReviewBot
On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 12:13 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced dynamic hashmap creation with c++11's static initialization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
>
> Diff: https://reviews.apache.org/r/35544/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 35544: containerizer: statically initialize
isolator factories
Posted by Michael Park <mc...@gmail.com>.
> On June 18, 2015, 3:17 a.m., Michael Park wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 135
> > <https://reviews.apache.org/r/35544/diff/1/?file=986152#file986152line135>
> >
> > While your analysis is correct, we need to use `get` here instead since `at` will throw an exception if the element is not found.
I see, we're relying on `contains` above to make sure the `at` doesn't throw here...
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88329
-----------------------------------------------------------
On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 12:13 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced dynamic hashmap creation with c++11's static initialization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
>
> Diff: https://reviews.apache.org/r/35544/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 35544: containerizer: statically initialize
isolator factories
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88329
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 134)
<https://reviews.apache.org/r/35544/#comment140803>
While your analysis is correct, we need to use `get` here instead since `at` will throw an exception if the element is not found.
- Michael Park
On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 12:13 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced dynamic hashmap creation with c++11's static initialization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
>
> Diff: https://reviews.apache.org/r/35544/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>
Re: Review Request 35544: containerizer: statically initialize
isolator factories
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35544/#review88603
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On June 17, 2015, 12:13 a.m., Jojy Varghese wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35544/
> -----------------------------------------------------------
>
> (Updated June 17, 2015, 12:13 a.m.)
>
>
> Review request for mesos and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced dynamic hashmap creation with c++11's static initialization.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
>
> Diff: https://reviews.apache.org/r/35544/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jojy Varghese
>
>