You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2016/02/02 15:56:04 UTC

Review Request 43092: [Ambari tarballs] Refactor postinstall and postremove scripts to use install-helper.sh exclusively

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43092/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-14877
    https://issues.apache.org/jira/browse/AMBARI-14877


Repository: ambari


Description
-------

We will need this refactoring, to use install-helper.sh while installing
tar.gz


Diffs
-----

  ambari-agent/conf/unix/install-helper.sh 185290c 
  ambari-agent/pom.xml 918065f 
  ambari-agent/src/main/package/deb/control/postinst ceca9be 
  ambari-agent/src/main/package/deb/control/posttrm 21a01fa 
  ambari-agent/src/main/package/deb/control/prerm 70a9c63 
  ambari-agent/src/main/package/rpm/postinstall.sh 56c6573 
  ambari-agent/src/main/package/rpm/preremove.sh 2078acd 
  ambari-server/conf/unix/install-helper.sh 2635694 
  ambari-server/pom.xml c601baa 
  ambari-server/src/main/package/deb/control/postinst c3b6235 
  ambari-server/src/main/package/deb/control/posttrm 21a01fa 
  ambari-server/src/main/package/deb/control/prerm 927ba4c 
  ambari-server/src/main/package/rpm/postinstall.sh 9b0b54a 
  ambari-server/src/main/package/rpm/preremove.sh 6febaa8 

Diff: https://reviews.apache.org/r/43092/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 43092: [Ambari tarballs] Refactor postinstall and postremove scripts to use install-helper.sh exclusively

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43092/#review117606
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 3, 2016, 11:50 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43092/
> -----------------------------------------------------------
> 
> (Updated Feb. 3, 2016, 11:50 a.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14877
>     https://issues.apache.org/jira/browse/AMBARI-14877
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We will need this refactoring, to use install-helper.sh while installing
> tar.gz
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/install-helper.sh 185290c 
>   ambari-agent/src/main/package/deb/control/postinst ceca9be 
>   ambari-agent/src/main/package/deb/control/posttrm 21a01fa 
>   ambari-agent/src/main/package/deb/control/prerm 70a9c63 
>   ambari-agent/src/main/package/rpm/postinstall.sh 56c6573 
>   ambari-agent/src/main/package/rpm/preremove.sh 2078acd 
>   ambari-agent/src/packages/tarball/all.xml d4ed2ff 
>   ambari-server/conf/unix/install-helper.sh 2635694 
>   ambari-server/src/main/assemblies/server.xml c24bce6 
>   ambari-server/src/main/package/deb/control/postinst c3b6235 
>   ambari-server/src/main/package/deb/control/posttrm 21a01fa 
>   ambari-server/src/main/package/deb/control/prerm 927ba4c 
>   ambari-server/src/main/package/rpm/postinstall.sh 9b0b54a 
>   ambari-server/src/main/package/rpm/preremove.sh 6febaa8 
> 
> Diff: https://reviews.apache.org/r/43092/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 43092: [Ambari tarballs] Refactor postinstall and postremove scripts to use install-helper.sh exclusively

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43092/
-----------------------------------------------------------

(Updated Feb. 3, 2016, 9:50 a.m.)


Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-14877
    https://issues.apache.org/jira/browse/AMBARI-14877


Repository: ambari


Description
-------

We will need this refactoring, to use install-helper.sh while installing
tar.gz


Diffs (updated)
-----

  ambari-agent/conf/unix/install-helper.sh 185290c 
  ambari-agent/src/main/package/deb/control/postinst ceca9be 
  ambari-agent/src/main/package/deb/control/posttrm 21a01fa 
  ambari-agent/src/main/package/deb/control/prerm 70a9c63 
  ambari-agent/src/main/package/rpm/postinstall.sh 56c6573 
  ambari-agent/src/main/package/rpm/preremove.sh 2078acd 
  ambari-agent/src/packages/tarball/all.xml d4ed2ff 
  ambari-server/conf/unix/install-helper.sh 2635694 
  ambari-server/src/main/assemblies/server.xml c24bce6 
  ambari-server/src/main/package/deb/control/postinst c3b6235 
  ambari-server/src/main/package/deb/control/posttrm 21a01fa 
  ambari-server/src/main/package/deb/control/prerm 927ba4c 
  ambari-server/src/main/package/rpm/postinstall.sh 9b0b54a 
  ambari-server/src/main/package/rpm/preremove.sh 6febaa8 

Diff: https://reviews.apache.org/r/43092/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 43092: [Ambari tarballs] Refactor postinstall and postremove scripts to use install-helper.sh exclusively

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43092/#review117412
-----------------------------------------------------------


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 2, 2016, 4:56 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43092/
> -----------------------------------------------------------
> 
> (Updated Feb. 2, 2016, 4:56 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-14877
>     https://issues.apache.org/jira/browse/AMBARI-14877
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> We will need this refactoring, to use install-helper.sh while installing
> tar.gz
> 
> 
> Diffs
> -----
> 
>   ambari-agent/conf/unix/install-helper.sh 185290c 
>   ambari-agent/pom.xml 918065f 
>   ambari-agent/src/main/package/deb/control/postinst ceca9be 
>   ambari-agent/src/main/package/deb/control/posttrm 21a01fa 
>   ambari-agent/src/main/package/deb/control/prerm 70a9c63 
>   ambari-agent/src/main/package/rpm/postinstall.sh 56c6573 
>   ambari-agent/src/main/package/rpm/preremove.sh 2078acd 
>   ambari-server/conf/unix/install-helper.sh 2635694 
>   ambari-server/pom.xml c601baa 
>   ambari-server/src/main/package/deb/control/postinst c3b6235 
>   ambari-server/src/main/package/deb/control/posttrm 21a01fa 
>   ambari-server/src/main/package/deb/control/prerm 927ba4c 
>   ambari-server/src/main/package/rpm/postinstall.sh 9b0b54a 
>   ambari-server/src/main/package/rpm/preremove.sh 6febaa8 
> 
> Diff: https://reviews.apache.org/r/43092/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>