You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Dániel Urbán <ur...@gmail.com> on 2020/08/10 08:48:53 UTC
Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and
consumer configuration override
Hi everyone,
Just a reminder, please vote if you are interested in this KIP being
implemented.
Thanks,
Daniel
Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. júl. 31., P,
9:01):
> Hi David,
>
> There is another PR linked on KAFKA-8507, which is still open:
> https://github.com/apache/kafka/pull/8123
> Wasn't sure if it will go in, and wanted to avoid conflicts. Do you think
> I should do the switch to '--bootstrap-server' anyway?
>
> Thanks,
> Daniel
>
> David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. júl. 30., Cs,
> 17:52):
>
>> Hi Daniel,
>>
>> Thanks for the KIP.
>>
>> It seems that we have forgotten to include this tool in KIP-499.
>> KAFKA-8507
>> is resolved
>> by this tool still uses the deprecated "--broker-list". I suggest to
>> include "--bootstrap-server"
>> in your public interfaces as well and fix this omission during the
>> implementation.
>>
>> +1 (non-binding)
>>
>> Thanks,
>> David
>>
>> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash <
>> kamal.chandraprakash@gmail.com> wrote:
>>
>> > +1 (non-binding), thanks for the KIP!
>> >
>> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <ma...@gmail.com>
>> > wrote:
>> >
>> > > +1 (binding)
>> > >
>> > > Thanks for the KIP!
>> > >
>> > >
>> > >
>> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <ur...@gmail.com>
>> > > wrote:
>> > >
>> > > > Hi everyone,
>> > > >
>> > > > If you are interested in this KIP, please do not forget to vote.
>> > > >
>> > > > Thanks,
>> > > > Daniel
>> > > >
>> > > > Viktor Somogyi-Vass <vi...@gmail.com> ezt írta (időpont:
>> 2020.
>> > > > júl.
>> > > > 28., K, 16:06):
>> > > >
>> > > > > +1 from me (non-binding), thanks for the KIP.
>> > > > >
>> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán <
>> urb.daniel7@gmail.com
>> > >
>> > > > > wrote:
>> > > > >
>> > > > > > Hello everyone,
>> > > > > >
>> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the
>> > > > GetOffsetShell
>> > > > > > tool by enabling querying multiple topic-partitions, adding new
>> > > > filtering
>> > > > > > options, and adding a config override option.
>> > > > > >
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override
>> > > > > >
>> > > > > > The original discussion thread was named "[DISCUSS] KIP-308:
>> > > > > > GetOffsetShell: new KafkaConsumer API, support for multiple
>> topics,
>> > > > > > minimize the number of requests to server". The id had to be
>> > changed
>> > > as
>> > > > > > there was a collision, and the KIP also had to be renamed, as
>> some
>> > of
>> > > > its
>> > > > > > motivations were outdated.
>> > > > > >
>> > > > > > Thanks,
>> > > > > > Daniel
>> > > > > >
>> > > > >
>> > > >
>> > >
>> >
>>
>
Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and
consumer configuration override
Posted by Mickael Maison <mi...@gmail.com>.
+1 (binding)
Thanks for the KIP Daniel
On Mon, Aug 31, 2020 at 2:31 PM Dániel Urbán <ur...@gmail.com> wrote:
>
> Hello everyone,
>
> I'd like to ask you to consider voting for this KIP, it only needs 2 more
> binding votes.
>
> This KIP focuses on the GetOffsetShell tool. The tool is useful for
> monitoring and investigations as well.
> Unfortunately, the tool misses one key, and some quality-of-life features:
> - Because of lack of configuration options, it cannot be used with secure
> clusters - which makes it unviable in many use-cases.
> - Only supports a single topic - usability improvement, also in line with
> other tools using pattern based matching.
> - Still utilizes the deprecated "--broker-list" argument name.
>
> Overall, I believe that this is a non-intrusive change - minor improvements
> without breaking changes. But for some, this would be a great improvement
> in using Kafka.
>
> Thank you in advance,
> Daniel
>
>
> Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 27., Cs,
> 17:52):
>
> > Hi all,
> >
> > Please vote if you'd like to see this implemented. This one fixes a
> > long-time debt, would be nice to see it pass.
> >
> > Thank you,
> > Daniel
> >
> > Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 18.,
> > K, 14:06):
> >
> >> Hello everyone,
> >>
> >> Please, if you are interested in this KIP and PR, don't forget to vote.
> >>
> >> Thank you,
> >> Daniel
> >>
> >> Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 13.,
> >> Cs, 14:00):
> >>
> >>> Hi David,
> >>>
> >>> Thank you for the suggestion. KIP-635 was referencing the --broker-list
> >>> issue, but based on your suggestion, I pinged the PR
> >>> https://github.com/apache/kafka/pull/8123.
> >>> Since I got no response, I updated KIP-635 to deprecate --broker-list.
> >>> Will update the PR related to KIP-635 to reflect that change.
> >>>
> >>> Thanks,
> >>> Daniel
> >>>
> >>> David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. aug. 10., H,
> >>> 20:48):
> >>>
> >>>> Hi Daniel,
> >>>>
> >>>> I was not aware of that PR. At minimum, I would add `--bootstrap-server`
> >>>> to the list in the KIP for completeness. Regarding the implementation,
> >>>> I would leave a comment in that PR asking if they plan to continue it.
> >>>> If
> >>>> not,
> >>>> we could do it as part of your PR directly.
> >>>>
> >>>> Cheers,
> >>>> David
> >>>>
> >>>> On Mon, Aug 10, 2020 at 10:49 AM Dániel Urbán <ur...@gmail.com>
> >>>> wrote:
> >>>>
> >>>> > Hi everyone,
> >>>> >
> >>>> > Just a reminder, please vote if you are interested in this KIP being
> >>>> > implemented.
> >>>> >
> >>>> > Thanks,
> >>>> > Daniel
> >>>> >
> >>>> > Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. júl.
> >>>> 31., P,
> >>>> > 9:01):
> >>>> >
> >>>> > > Hi David,
> >>>> > >
> >>>> > > There is another PR linked on KAFKA-8507, which is still open:
> >>>> > > https://github.com/apache/kafka/pull/8123
> >>>> > > Wasn't sure if it will go in, and wanted to avoid conflicts. Do you
> >>>> think
> >>>> > > I should do the switch to '--bootstrap-server' anyway?
> >>>> > >
> >>>> > > Thanks,
> >>>> > > Daniel
> >>>> > >
> >>>> > > David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. júl.
> >>>> 30., Cs,
> >>>> > > 17:52):
> >>>> > >
> >>>> > >> Hi Daniel,
> >>>> > >>
> >>>> > >> Thanks for the KIP.
> >>>> > >>
> >>>> > >> It seems that we have forgotten to include this tool in KIP-499.
> >>>> > >> KAFKA-8507
> >>>> > >> is resolved
> >>>> > >> by this tool still uses the deprecated "--broker-list". I suggest
> >>>> to
> >>>> > >> include "--bootstrap-server"
> >>>> > >> in your public interfaces as well and fix this omission during the
> >>>> > >> implementation.
> >>>> > >>
> >>>> > >> +1 (non-binding)
> >>>> > >>
> >>>> > >> Thanks,
> >>>> > >> David
> >>>> > >>
> >>>> > >> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash <
> >>>> > >> kamal.chandraprakash@gmail.com> wrote:
> >>>> > >>
> >>>> > >> > +1 (non-binding), thanks for the KIP!
> >>>> > >> >
> >>>> > >> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <
> >>>> manikumar.reddy@gmail.com>
> >>>> > >> > wrote:
> >>>> > >> >
> >>>> > >> > > +1 (binding)
> >>>> > >> > >
> >>>> > >> > > Thanks for the KIP!
> >>>> > >> > >
> >>>> > >> > >
> >>>> > >> > >
> >>>> > >> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <
> >>>> urb.daniel7@gmail.com
> >>>> > >
> >>>> > >> > > wrote:
> >>>> > >> > >
> >>>> > >> > > > Hi everyone,
> >>>> > >> > > >
> >>>> > >> > > > If you are interested in this KIP, please do not forget to
> >>>> vote.
> >>>> > >> > > >
> >>>> > >> > > > Thanks,
> >>>> > >> > > > Daniel
> >>>> > >> > > >
> >>>> > >> > > > Viktor Somogyi-Vass <vi...@gmail.com> ezt írta
> >>>> (időpont:
> >>>> > >> 2020.
> >>>> > >> > > > júl.
> >>>> > >> > > > 28., K, 16:06):
> >>>> > >> > > >
> >>>> > >> > > > > +1 from me (non-binding), thanks for the KIP.
> >>>> > >> > > > >
> >>>> > >> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán <
> >>>> > >> urb.daniel7@gmail.com
> >>>> > >> > >
> >>>> > >> > > > > wrote:
> >>>> > >> > > > >
> >>>> > >> > > > > > Hello everyone,
> >>>> > >> > > > > >
> >>>> > >> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the
> >>>> > >> > > > GetOffsetShell
> >>>> > >> > > > > > tool by enabling querying multiple topic-partitions,
> >>>> adding
> >>>> > new
> >>>> > >> > > > filtering
> >>>> > >> > > > > > options, and adding a config override option.
> >>>> > >> > > > > >
> >>>> > >> > > > > >
> >>>> > >> > > > >
> >>>> > >> > > >
> >>>> > >> > >
> >>>> > >> >
> >>>> > >>
> >>>> >
> >>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override
> >>>> > >> > > > > >
> >>>> > >> > > > > > The original discussion thread was named "[DISCUSS]
> >>>> KIP-308:
> >>>> > >> > > > > > GetOffsetShell: new KafkaConsumer API, support for
> >>>> multiple
> >>>> > >> topics,
> >>>> > >> > > > > > minimize the number of requests to server". The id had
> >>>> to be
> >>>> > >> > changed
> >>>> > >> > > as
> >>>> > >> > > > > > there was a collision, and the KIP also had to be
> >>>> renamed, as
> >>>> > >> some
> >>>> > >> > of
> >>>> > >> > > > its
> >>>> > >> > > > > > motivations were outdated.
> >>>> > >> > > > > >
> >>>> > >> > > > > > Thanks,
> >>>> > >> > > > > > Daniel
> >>>> > >> > > > > >
> >>>> > >> > > > >
> >>>> > >> > > >
> >>>> > >> > >
> >>>> > >> >
> >>>> > >>
> >>>> > >
> >>>> >
> >>>>
> >>>
Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and
consumer configuration override
Posted by Dániel Urbán <ur...@gmail.com>.
Hello everyone,
I'd like to ask you to consider voting for this KIP, it only needs 2 more
binding votes.
This KIP focuses on the GetOffsetShell tool. The tool is useful for
monitoring and investigations as well.
Unfortunately, the tool misses one key, and some quality-of-life features:
- Because of lack of configuration options, it cannot be used with secure
clusters - which makes it unviable in many use-cases.
- Only supports a single topic - usability improvement, also in line with
other tools using pattern based matching.
- Still utilizes the deprecated "--broker-list" argument name.
Overall, I believe that this is a non-intrusive change - minor improvements
without breaking changes. But for some, this would be a great improvement
in using Kafka.
Thank you in advance,
Daniel
Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 27., Cs,
17:52):
> Hi all,
>
> Please vote if you'd like to see this implemented. This one fixes a
> long-time debt, would be nice to see it pass.
>
> Thank you,
> Daniel
>
> Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 18.,
> K, 14:06):
>
>> Hello everyone,
>>
>> Please, if you are interested in this KIP and PR, don't forget to vote.
>>
>> Thank you,
>> Daniel
>>
>> Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 13.,
>> Cs, 14:00):
>>
>>> Hi David,
>>>
>>> Thank you for the suggestion. KIP-635 was referencing the --broker-list
>>> issue, but based on your suggestion, I pinged the PR
>>> https://github.com/apache/kafka/pull/8123.
>>> Since I got no response, I updated KIP-635 to deprecate --broker-list.
>>> Will update the PR related to KIP-635 to reflect that change.
>>>
>>> Thanks,
>>> Daniel
>>>
>>> David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. aug. 10., H,
>>> 20:48):
>>>
>>>> Hi Daniel,
>>>>
>>>> I was not aware of that PR. At minimum, I would add `--bootstrap-server`
>>>> to the list in the KIP for completeness. Regarding the implementation,
>>>> I would leave a comment in that PR asking if they plan to continue it.
>>>> If
>>>> not,
>>>> we could do it as part of your PR directly.
>>>>
>>>> Cheers,
>>>> David
>>>>
>>>> On Mon, Aug 10, 2020 at 10:49 AM Dániel Urbán <ur...@gmail.com>
>>>> wrote:
>>>>
>>>> > Hi everyone,
>>>> >
>>>> > Just a reminder, please vote if you are interested in this KIP being
>>>> > implemented.
>>>> >
>>>> > Thanks,
>>>> > Daniel
>>>> >
>>>> > Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. júl.
>>>> 31., P,
>>>> > 9:01):
>>>> >
>>>> > > Hi David,
>>>> > >
>>>> > > There is another PR linked on KAFKA-8507, which is still open:
>>>> > > https://github.com/apache/kafka/pull/8123
>>>> > > Wasn't sure if it will go in, and wanted to avoid conflicts. Do you
>>>> think
>>>> > > I should do the switch to '--bootstrap-server' anyway?
>>>> > >
>>>> > > Thanks,
>>>> > > Daniel
>>>> > >
>>>> > > David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. júl.
>>>> 30., Cs,
>>>> > > 17:52):
>>>> > >
>>>> > >> Hi Daniel,
>>>> > >>
>>>> > >> Thanks for the KIP.
>>>> > >>
>>>> > >> It seems that we have forgotten to include this tool in KIP-499.
>>>> > >> KAFKA-8507
>>>> > >> is resolved
>>>> > >> by this tool still uses the deprecated "--broker-list". I suggest
>>>> to
>>>> > >> include "--bootstrap-server"
>>>> > >> in your public interfaces as well and fix this omission during the
>>>> > >> implementation.
>>>> > >>
>>>> > >> +1 (non-binding)
>>>> > >>
>>>> > >> Thanks,
>>>> > >> David
>>>> > >>
>>>> > >> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash <
>>>> > >> kamal.chandraprakash@gmail.com> wrote:
>>>> > >>
>>>> > >> > +1 (non-binding), thanks for the KIP!
>>>> > >> >
>>>> > >> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <
>>>> manikumar.reddy@gmail.com>
>>>> > >> > wrote:
>>>> > >> >
>>>> > >> > > +1 (binding)
>>>> > >> > >
>>>> > >> > > Thanks for the KIP!
>>>> > >> > >
>>>> > >> > >
>>>> > >> > >
>>>> > >> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <
>>>> urb.daniel7@gmail.com
>>>> > >
>>>> > >> > > wrote:
>>>> > >> > >
>>>> > >> > > > Hi everyone,
>>>> > >> > > >
>>>> > >> > > > If you are interested in this KIP, please do not forget to
>>>> vote.
>>>> > >> > > >
>>>> > >> > > > Thanks,
>>>> > >> > > > Daniel
>>>> > >> > > >
>>>> > >> > > > Viktor Somogyi-Vass <vi...@gmail.com> ezt írta
>>>> (időpont:
>>>> > >> 2020.
>>>> > >> > > > júl.
>>>> > >> > > > 28., K, 16:06):
>>>> > >> > > >
>>>> > >> > > > > +1 from me (non-binding), thanks for the KIP.
>>>> > >> > > > >
>>>> > >> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán <
>>>> > >> urb.daniel7@gmail.com
>>>> > >> > >
>>>> > >> > > > > wrote:
>>>> > >> > > > >
>>>> > >> > > > > > Hello everyone,
>>>> > >> > > > > >
>>>> > >> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the
>>>> > >> > > > GetOffsetShell
>>>> > >> > > > > > tool by enabling querying multiple topic-partitions,
>>>> adding
>>>> > new
>>>> > >> > > > filtering
>>>> > >> > > > > > options, and adding a config override option.
>>>> > >> > > > > >
>>>> > >> > > > > >
>>>> > >> > > > >
>>>> > >> > > >
>>>> > >> > >
>>>> > >> >
>>>> > >>
>>>> >
>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override
>>>> > >> > > > > >
>>>> > >> > > > > > The original discussion thread was named "[DISCUSS]
>>>> KIP-308:
>>>> > >> > > > > > GetOffsetShell: new KafkaConsumer API, support for
>>>> multiple
>>>> > >> topics,
>>>> > >> > > > > > minimize the number of requests to server". The id had
>>>> to be
>>>> > >> > changed
>>>> > >> > > as
>>>> > >> > > > > > there was a collision, and the KIP also had to be
>>>> renamed, as
>>>> > >> some
>>>> > >> > of
>>>> > >> > > > its
>>>> > >> > > > > > motivations were outdated.
>>>> > >> > > > > >
>>>> > >> > > > > > Thanks,
>>>> > >> > > > > > Daniel
>>>> > >> > > > > >
>>>> > >> > > > >
>>>> > >> > > >
>>>> > >> > >
>>>> > >> >
>>>> > >>
>>>> > >
>>>> >
>>>>
>>>
Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and
consumer configuration override
Posted by Dániel Urbán <ur...@gmail.com>.
Hi all,
Please vote if you'd like to see this implemented. This one fixes a
long-time debt, would be nice to see it pass.
Thank you,
Daniel
Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 18., K,
14:06):
> Hello everyone,
>
> Please, if you are interested in this KIP and PR, don't forget to vote.
>
> Thank you,
> Daniel
>
> Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 13.,
> Cs, 14:00):
>
>> Hi David,
>>
>> Thank you for the suggestion. KIP-635 was referencing the --broker-list
>> issue, but based on your suggestion, I pinged the PR
>> https://github.com/apache/kafka/pull/8123.
>> Since I got no response, I updated KIP-635 to deprecate --broker-list.
>> Will update the PR related to KIP-635 to reflect that change.
>>
>> Thanks,
>> Daniel
>>
>> David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. aug. 10., H,
>> 20:48):
>>
>>> Hi Daniel,
>>>
>>> I was not aware of that PR. At minimum, I would add `--bootstrap-server`
>>> to the list in the KIP for completeness. Regarding the implementation,
>>> I would leave a comment in that PR asking if they plan to continue it. If
>>> not,
>>> we could do it as part of your PR directly.
>>>
>>> Cheers,
>>> David
>>>
>>> On Mon, Aug 10, 2020 at 10:49 AM Dániel Urbán <ur...@gmail.com>
>>> wrote:
>>>
>>> > Hi everyone,
>>> >
>>> > Just a reminder, please vote if you are interested in this KIP being
>>> > implemented.
>>> >
>>> > Thanks,
>>> > Daniel
>>> >
>>> > Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. júl.
>>> 31., P,
>>> > 9:01):
>>> >
>>> > > Hi David,
>>> > >
>>> > > There is another PR linked on KAFKA-8507, which is still open:
>>> > > https://github.com/apache/kafka/pull/8123
>>> > > Wasn't sure if it will go in, and wanted to avoid conflicts. Do you
>>> think
>>> > > I should do the switch to '--bootstrap-server' anyway?
>>> > >
>>> > > Thanks,
>>> > > Daniel
>>> > >
>>> > > David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. júl.
>>> 30., Cs,
>>> > > 17:52):
>>> > >
>>> > >> Hi Daniel,
>>> > >>
>>> > >> Thanks for the KIP.
>>> > >>
>>> > >> It seems that we have forgotten to include this tool in KIP-499.
>>> > >> KAFKA-8507
>>> > >> is resolved
>>> > >> by this tool still uses the deprecated "--broker-list". I suggest to
>>> > >> include "--bootstrap-server"
>>> > >> in your public interfaces as well and fix this omission during the
>>> > >> implementation.
>>> > >>
>>> > >> +1 (non-binding)
>>> > >>
>>> > >> Thanks,
>>> > >> David
>>> > >>
>>> > >> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash <
>>> > >> kamal.chandraprakash@gmail.com> wrote:
>>> > >>
>>> > >> > +1 (non-binding), thanks for the KIP!
>>> > >> >
>>> > >> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <
>>> manikumar.reddy@gmail.com>
>>> > >> > wrote:
>>> > >> >
>>> > >> > > +1 (binding)
>>> > >> > >
>>> > >> > > Thanks for the KIP!
>>> > >> > >
>>> > >> > >
>>> > >> > >
>>> > >> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <
>>> urb.daniel7@gmail.com
>>> > >
>>> > >> > > wrote:
>>> > >> > >
>>> > >> > > > Hi everyone,
>>> > >> > > >
>>> > >> > > > If you are interested in this KIP, please do not forget to
>>> vote.
>>> > >> > > >
>>> > >> > > > Thanks,
>>> > >> > > > Daniel
>>> > >> > > >
>>> > >> > > > Viktor Somogyi-Vass <vi...@gmail.com> ezt írta
>>> (időpont:
>>> > >> 2020.
>>> > >> > > > júl.
>>> > >> > > > 28., K, 16:06):
>>> > >> > > >
>>> > >> > > > > +1 from me (non-binding), thanks for the KIP.
>>> > >> > > > >
>>> > >> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán <
>>> > >> urb.daniel7@gmail.com
>>> > >> > >
>>> > >> > > > > wrote:
>>> > >> > > > >
>>> > >> > > > > > Hello everyone,
>>> > >> > > > > >
>>> > >> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the
>>> > >> > > > GetOffsetShell
>>> > >> > > > > > tool by enabling querying multiple topic-partitions,
>>> adding
>>> > new
>>> > >> > > > filtering
>>> > >> > > > > > options, and adding a config override option.
>>> > >> > > > > >
>>> > >> > > > > >
>>> > >> > > > >
>>> > >> > > >
>>> > >> > >
>>> > >> >
>>> > >>
>>> >
>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override
>>> > >> > > > > >
>>> > >> > > > > > The original discussion thread was named "[DISCUSS]
>>> KIP-308:
>>> > >> > > > > > GetOffsetShell: new KafkaConsumer API, support for
>>> multiple
>>> > >> topics,
>>> > >> > > > > > minimize the number of requests to server". The id had to
>>> be
>>> > >> > changed
>>> > >> > > as
>>> > >> > > > > > there was a collision, and the KIP also had to be
>>> renamed, as
>>> > >> some
>>> > >> > of
>>> > >> > > > its
>>> > >> > > > > > motivations were outdated.
>>> > >> > > > > >
>>> > >> > > > > > Thanks,
>>> > >> > > > > > Daniel
>>> > >> > > > > >
>>> > >> > > > >
>>> > >> > > >
>>> > >> > >
>>> > >> >
>>> > >>
>>> > >
>>> >
>>>
>>
Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and
consumer configuration override
Posted by Dániel Urbán <ur...@gmail.com>.
Hello everyone,
Please, if you are interested in this KIP and PR, don't forget to vote.
Thank you,
Daniel
Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. aug. 13., Cs,
14:00):
> Hi David,
>
> Thank you for the suggestion. KIP-635 was referencing the --broker-list
> issue, but based on your suggestion, I pinged the PR
> https://github.com/apache/kafka/pull/8123.
> Since I got no response, I updated KIP-635 to deprecate --broker-list.
> Will update the PR related to KIP-635 to reflect that change.
>
> Thanks,
> Daniel
>
> David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. aug. 10., H,
> 20:48):
>
>> Hi Daniel,
>>
>> I was not aware of that PR. At minimum, I would add `--bootstrap-server`
>> to the list in the KIP for completeness. Regarding the implementation,
>> I would leave a comment in that PR asking if they plan to continue it. If
>> not,
>> we could do it as part of your PR directly.
>>
>> Cheers,
>> David
>>
>> On Mon, Aug 10, 2020 at 10:49 AM Dániel Urbán <ur...@gmail.com>
>> wrote:
>>
>> > Hi everyone,
>> >
>> > Just a reminder, please vote if you are interested in this KIP being
>> > implemented.
>> >
>> > Thanks,
>> > Daniel
>> >
>> > Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. júl.
>> 31., P,
>> > 9:01):
>> >
>> > > Hi David,
>> > >
>> > > There is another PR linked on KAFKA-8507, which is still open:
>> > > https://github.com/apache/kafka/pull/8123
>> > > Wasn't sure if it will go in, and wanted to avoid conflicts. Do you
>> think
>> > > I should do the switch to '--bootstrap-server' anyway?
>> > >
>> > > Thanks,
>> > > Daniel
>> > >
>> > > David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. júl. 30.,
>> Cs,
>> > > 17:52):
>> > >
>> > >> Hi Daniel,
>> > >>
>> > >> Thanks for the KIP.
>> > >>
>> > >> It seems that we have forgotten to include this tool in KIP-499.
>> > >> KAFKA-8507
>> > >> is resolved
>> > >> by this tool still uses the deprecated "--broker-list". I suggest to
>> > >> include "--bootstrap-server"
>> > >> in your public interfaces as well and fix this omission during the
>> > >> implementation.
>> > >>
>> > >> +1 (non-binding)
>> > >>
>> > >> Thanks,
>> > >> David
>> > >>
>> > >> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash <
>> > >> kamal.chandraprakash@gmail.com> wrote:
>> > >>
>> > >> > +1 (non-binding), thanks for the KIP!
>> > >> >
>> > >> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <
>> manikumar.reddy@gmail.com>
>> > >> > wrote:
>> > >> >
>> > >> > > +1 (binding)
>> > >> > >
>> > >> > > Thanks for the KIP!
>> > >> > >
>> > >> > >
>> > >> > >
>> > >> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <
>> urb.daniel7@gmail.com
>> > >
>> > >> > > wrote:
>> > >> > >
>> > >> > > > Hi everyone,
>> > >> > > >
>> > >> > > > If you are interested in this KIP, please do not forget to
>> vote.
>> > >> > > >
>> > >> > > > Thanks,
>> > >> > > > Daniel
>> > >> > > >
>> > >> > > > Viktor Somogyi-Vass <vi...@gmail.com> ezt írta
>> (időpont:
>> > >> 2020.
>> > >> > > > júl.
>> > >> > > > 28., K, 16:06):
>> > >> > > >
>> > >> > > > > +1 from me (non-binding), thanks for the KIP.
>> > >> > > > >
>> > >> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán <
>> > >> urb.daniel7@gmail.com
>> > >> > >
>> > >> > > > > wrote:
>> > >> > > > >
>> > >> > > > > > Hello everyone,
>> > >> > > > > >
>> > >> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the
>> > >> > > > GetOffsetShell
>> > >> > > > > > tool by enabling querying multiple topic-partitions, adding
>> > new
>> > >> > > > filtering
>> > >> > > > > > options, and adding a config override option.
>> > >> > > > > >
>> > >> > > > > >
>> > >> > > > >
>> > >> > > >
>> > >> > >
>> > >> >
>> > >>
>> >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override
>> > >> > > > > >
>> > >> > > > > > The original discussion thread was named "[DISCUSS]
>> KIP-308:
>> > >> > > > > > GetOffsetShell: new KafkaConsumer API, support for multiple
>> > >> topics,
>> > >> > > > > > minimize the number of requests to server". The id had to
>> be
>> > >> > changed
>> > >> > > as
>> > >> > > > > > there was a collision, and the KIP also had to be renamed,
>> as
>> > >> some
>> > >> > of
>> > >> > > > its
>> > >> > > > > > motivations were outdated.
>> > >> > > > > >
>> > >> > > > > > Thanks,
>> > >> > > > > > Daniel
>> > >> > > > > >
>> > >> > > > >
>> > >> > > >
>> > >> > >
>> > >> >
>> > >>
>> > >
>> >
>>
>
Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and
consumer configuration override
Posted by Dániel Urbán <ur...@gmail.com>.
Hi David,
Thank you for the suggestion. KIP-635 was referencing the --broker-list
issue, but based on your suggestion, I pinged the PR
https://github.com/apache/kafka/pull/8123.
Since I got no response, I updated KIP-635 to deprecate --broker-list. Will
update the PR related to KIP-635 to reflect that change.
Thanks,
Daniel
David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. aug. 10., H,
20:48):
> Hi Daniel,
>
> I was not aware of that PR. At minimum, I would add `--bootstrap-server`
> to the list in the KIP for completeness. Regarding the implementation,
> I would leave a comment in that PR asking if they plan to continue it. If
> not,
> we could do it as part of your PR directly.
>
> Cheers,
> David
>
> On Mon, Aug 10, 2020 at 10:49 AM Dániel Urbán <ur...@gmail.com>
> wrote:
>
> > Hi everyone,
> >
> > Just a reminder, please vote if you are interested in this KIP being
> > implemented.
> >
> > Thanks,
> > Daniel
> >
> > Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. júl. 31.,
> P,
> > 9:01):
> >
> > > Hi David,
> > >
> > > There is another PR linked on KAFKA-8507, which is still open:
> > > https://github.com/apache/kafka/pull/8123
> > > Wasn't sure if it will go in, and wanted to avoid conflicts. Do you
> think
> > > I should do the switch to '--bootstrap-server' anyway?
> > >
> > > Thanks,
> > > Daniel
> > >
> > > David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. júl. 30.,
> Cs,
> > > 17:52):
> > >
> > >> Hi Daniel,
> > >>
> > >> Thanks for the KIP.
> > >>
> > >> It seems that we have forgotten to include this tool in KIP-499.
> > >> KAFKA-8507
> > >> is resolved
> > >> by this tool still uses the deprecated "--broker-list". I suggest to
> > >> include "--bootstrap-server"
> > >> in your public interfaces as well and fix this omission during the
> > >> implementation.
> > >>
> > >> +1 (non-binding)
> > >>
> > >> Thanks,
> > >> David
> > >>
> > >> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash <
> > >> kamal.chandraprakash@gmail.com> wrote:
> > >>
> > >> > +1 (non-binding), thanks for the KIP!
> > >> >
> > >> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <
> manikumar.reddy@gmail.com>
> > >> > wrote:
> > >> >
> > >> > > +1 (binding)
> > >> > >
> > >> > > Thanks for the KIP!
> > >> > >
> > >> > >
> > >> > >
> > >> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <
> urb.daniel7@gmail.com
> > >
> > >> > > wrote:
> > >> > >
> > >> > > > Hi everyone,
> > >> > > >
> > >> > > > If you are interested in this KIP, please do not forget to vote.
> > >> > > >
> > >> > > > Thanks,
> > >> > > > Daniel
> > >> > > >
> > >> > > > Viktor Somogyi-Vass <vi...@gmail.com> ezt írta
> (időpont:
> > >> 2020.
> > >> > > > júl.
> > >> > > > 28., K, 16:06):
> > >> > > >
> > >> > > > > +1 from me (non-binding), thanks for the KIP.
> > >> > > > >
> > >> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán <
> > >> urb.daniel7@gmail.com
> > >> > >
> > >> > > > > wrote:
> > >> > > > >
> > >> > > > > > Hello everyone,
> > >> > > > > >
> > >> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the
> > >> > > > GetOffsetShell
> > >> > > > > > tool by enabling querying multiple topic-partitions, adding
> > new
> > >> > > > filtering
> > >> > > > > > options, and adding a config override option.
> > >> > > > > >
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override
> > >> > > > > >
> > >> > > > > > The original discussion thread was named "[DISCUSS] KIP-308:
> > >> > > > > > GetOffsetShell: new KafkaConsumer API, support for multiple
> > >> topics,
> > >> > > > > > minimize the number of requests to server". The id had to be
> > >> > changed
> > >> > > as
> > >> > > > > > there was a collision, and the KIP also had to be renamed,
> as
> > >> some
> > >> > of
> > >> > > > its
> > >> > > > > > motivations were outdated.
> > >> > > > > >
> > >> > > > > > Thanks,
> > >> > > > > > Daniel
> > >> > > > > >
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> >
>
Re: [VOTE] KIP-635: GetOffsetShell: support for multiple topics and
consumer configuration override
Posted by David Jacot <dj...@confluent.io>.
Hi Daniel,
I was not aware of that PR. At minimum, I would add `--bootstrap-server`
to the list in the KIP for completeness. Regarding the implementation,
I would leave a comment in that PR asking if they plan to continue it. If
not,
we could do it as part of your PR directly.
Cheers,
David
On Mon, Aug 10, 2020 at 10:49 AM Dániel Urbán <ur...@gmail.com> wrote:
> Hi everyone,
>
> Just a reminder, please vote if you are interested in this KIP being
> implemented.
>
> Thanks,
> Daniel
>
> Dániel Urbán <ur...@gmail.com> ezt írta (időpont: 2020. júl. 31., P,
> 9:01):
>
> > Hi David,
> >
> > There is another PR linked on KAFKA-8507, which is still open:
> > https://github.com/apache/kafka/pull/8123
> > Wasn't sure if it will go in, and wanted to avoid conflicts. Do you think
> > I should do the switch to '--bootstrap-server' anyway?
> >
> > Thanks,
> > Daniel
> >
> > David Jacot <dj...@confluent.io> ezt írta (időpont: 2020. júl. 30., Cs,
> > 17:52):
> >
> >> Hi Daniel,
> >>
> >> Thanks for the KIP.
> >>
> >> It seems that we have forgotten to include this tool in KIP-499.
> >> KAFKA-8507
> >> is resolved
> >> by this tool still uses the deprecated "--broker-list". I suggest to
> >> include "--bootstrap-server"
> >> in your public interfaces as well and fix this omission during the
> >> implementation.
> >>
> >> +1 (non-binding)
> >>
> >> Thanks,
> >> David
> >>
> >> On Thu, Jul 30, 2020 at 1:52 PM Kamal Chandraprakash <
> >> kamal.chandraprakash@gmail.com> wrote:
> >>
> >> > +1 (non-binding), thanks for the KIP!
> >> >
> >> > On Thu, Jul 30, 2020 at 3:31 PM Manikumar <ma...@gmail.com>
> >> > wrote:
> >> >
> >> > > +1 (binding)
> >> > >
> >> > > Thanks for the KIP!
> >> > >
> >> > >
> >> > >
> >> > > On Thu, Jul 30, 2020 at 3:07 PM Dániel Urbán <urb.daniel7@gmail.com
> >
> >> > > wrote:
> >> > >
> >> > > > Hi everyone,
> >> > > >
> >> > > > If you are interested in this KIP, please do not forget to vote.
> >> > > >
> >> > > > Thanks,
> >> > > > Daniel
> >> > > >
> >> > > > Viktor Somogyi-Vass <vi...@gmail.com> ezt írta (időpont:
> >> 2020.
> >> > > > júl.
> >> > > > 28., K, 16:06):
> >> > > >
> >> > > > > +1 from me (non-binding), thanks for the KIP.
> >> > > > >
> >> > > > > On Mon, Jul 27, 2020 at 10:02 AM Dániel Urbán <
> >> urb.daniel7@gmail.com
> >> > >
> >> > > > > wrote:
> >> > > > >
> >> > > > > > Hello everyone,
> >> > > > > >
> >> > > > > > I'd like to start a vote on KIP-635. The KIP enhances the
> >> > > > GetOffsetShell
> >> > > > > > tool by enabling querying multiple topic-partitions, adding
> new
> >> > > > filtering
> >> > > > > > options, and adding a config override option.
> >> > > > > >
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-635%3A+GetOffsetShell%3A+support+for+multiple+topics+and+consumer+configuration+override
> >> > > > > >
> >> > > > > > The original discussion thread was named "[DISCUSS] KIP-308:
> >> > > > > > GetOffsetShell: new KafkaConsumer API, support for multiple
> >> topics,
> >> > > > > > minimize the number of requests to server". The id had to be
> >> > changed
> >> > > as
> >> > > > > > there was a collision, and the KIP also had to be renamed, as
> >> some
> >> > of
> >> > > > its
> >> > > > > > motivations were outdated.
> >> > > > > >
> >> > > > > > Thanks,
> >> > > > > > Daniel
> >> > > > > >
> >> > > > >
> >> > > >
> >> > >
> >> >
> >>
> >
>