You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/10/29 18:21:27 UTC

[GitHub] [ignite] timotheuspreisinger opened a new pull request #9531: IGNITE-15820 .NET: Fix thin client streamer not creating SQL table entries

timotheuspreisinger opened a new pull request #9531:
URL: https://github.com/apache/ignite/pull/9531


   When using binary streaming for from a .NET Thin Client, objects sent to Ignite are processed in method org.apache.ignite.internal.processors.platform.client.streamer.ClientDataStreamerReader.readCacheObject(...). There, all objects read from the stream are boxed in a CacheObjectImpl instance. As through the binary streaming only instances of BinaryObjectImpl are received through the stream, this is unnecessary. Moreover, by the wrapping, the object sent to Ignite is not visible as a SQL table entry. 
   
   This is a problem specific to the Thin Client. It does not occur when using binary streaming on an (IIgnite) server object.
   
   Sample code is provided in Jira: https://issues.apache.org/jira/browse/IGNITE-15820
   
   
   Thank you for submitting the pull request to the Apache Ignite.
   
   In order to streamline the review of the contribution 
   we ask you to ensure the following steps have been taken:
   
   ### The Contribution Checklist
   - [X] There is a single JIRA ticket related to the pull request. 
   - [X] The web-link to the pull request is attached to the JIRA ticket.
   - [X] The JIRA ticket has the _Patch Available_ state.
   - [X] The pull request body describes changes that have been made. 
   The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
   - [X] The pull request title is treated as the final commit message. 
   The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
   - [X] A reviewer has been mentioned through the JIRA comments 
   (see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers)) 
   - [ ] The pull request has been checked by the Teamcity Bot and 
   the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
   
   ### Notes
   - [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
   - [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
   - [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
   - [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
   
   If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timotheuspreisinger closed pull request #9531: IGNITE-15820 .NET: Fix thin client streamer not creating SQL table entries

Posted by GitBox <gi...@apache.org>.
timotheuspreisinger closed pull request #9531:
URL: https://github.com/apache/ignite/pull/9531


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ptupitsyn commented on pull request #9531: IGNITE-15820 Streaming from .NET Thin Client does not create table entries

Posted by GitBox <gi...@apache.org>.
ptupitsyn commented on pull request #9531:
URL: https://github.com/apache/ignite/pull/9531#issuecomment-952629588


   Please add a test on the .NET side to verify the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ptupitsyn removed a comment on pull request #9531: IGNITE-15820 Streaming from .NET Thin Client does not create table entries

Posted by GitBox <gi...@apache.org>.
ptupitsyn removed a comment on pull request #9531:
URL: https://github.com/apache/ignite/pull/9531#issuecomment-952629588


   Please add a test on the .NET side to verify the fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ptupitsyn merged pull request #9531: IGNITE-15820 .NET: Fix thin client streamer not creating SQL table entries

Posted by GitBox <gi...@apache.org>.
ptupitsyn merged pull request #9531:
URL: https://github.com/apache/ignite/pull/9531


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] timotheuspreisinger commented on pull request #9531: IGNITE-15820 .NET: Fix thin client streamer not creating SQL table entries

Posted by GitBox <gi...@apache.org>.
timotheuspreisinger commented on pull request #9531:
URL: https://github.com/apache/ignite/pull/9531#issuecomment-954954027


   > Please add a test on the .NET side to verify the fix.
   
   Test added.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] ptupitsyn merged pull request #9531: IGNITE-15820 .NET: Fix thin client streamer not creating SQL table entries

Posted by GitBox <gi...@apache.org>.
ptupitsyn merged pull request #9531:
URL: https://github.com/apache/ignite/pull/9531


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org