Re: Review Request: Cloudstack-711 Cpu and ram overcommit at cluster level.

[Nitin Mehta <ni...@citrix.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9156/#review15988
-----------------------------------------------------------



server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34286>

    Can you add english comments as to what you doing here ?



server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34287>

    keep this with actualTotalCpu



server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34291>

    If we are going down this path for cpu and ram we should do the same for storage as well



server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34285>

    lets not mix the terms overprovisioning and overcommit...lets be consistent...we have been using overprovisioning so please stick to it



server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34288>

    with this logic change you will need to recreate these values for existing entries in op host capacity



server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34289>

    expensive



server/src/com/cloud/capacity/CapacityManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34290>

    make sure that the logging is consistent...please...you would want to show the over provisioned cpu and ram.



server/src/com/cloud/resource/ResourceManagerImpl.java
<https://reviews.apache.org/r/9156/#comment34292>

    What does this mean ? Is this logic broken for other hypervisors ?


- Nitin Mehta


On Jan. 30, 2013, 3:05 p.m., bharat kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9156/
> -----------------------------------------------------------
> 
> (Updated Jan. 30, 2013, 3:05 p.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek, Prachi Damle, and Nitin Mehta.
> 
> 
> Description
> -------
> 
> This patch enables cpu and ram overcommit on a per cluster basis(only for xenserver.).
> The dashboard will show actual values instead of the overcommit values.
> 
> 
> This addresses bug CLOUDSTACK-711.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/VirtualMachineProfile.java 0fab443 
>   api/src/org/apache/cloudstack/api/ApiConstants.java 58a7831 
>   api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java c64883c 
>   api/src/org/apache/cloudstack/api/response/ClusterResponse.java e436c99 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java 065d3be 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java 0ce91bc 
>   plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XenServer56FP1Resource.java 58b8a03 
>   server/src/com/cloud/agent/manager/allocator/impl/FirstFitAllocator.java 2a5258c 
>   server/src/com/cloud/api/ApiDBUtils.java 0b08b26 
>   server/src/com/cloud/api/ApiResponseHelper.java 1c8849a 
>   server/src/com/cloud/capacity/CapacityManager.java fffb41f 
>   server/src/com/cloud/capacity/CapacityManagerImpl.java c410109 
>   server/src/com/cloud/capacity/dao/CapacityDao.java 0c0723b 
>   server/src/com/cloud/capacity/dao/CapacityDaoImpl.java a2df475 
>   server/src/com/cloud/deploy/BareMetalPlanner.java 7616a38 
>   server/src/com/cloud/deploy/FirstFitPlanner.java 06e46fb 
>   server/src/com/cloud/hypervisor/HypervisorGuruBase.java 2efe6d3 
>   server/src/com/cloud/resource/ResourceManagerImpl.java f82424a 
>   server/src/com/cloud/vm/VirtualMachineManagerImpl.java e0647bb 
>   server/src/com/cloud/vm/VirtualMachineProfileImpl.java e83d6a0 
> 
> Diff: https://reviews.apache.org/r/9156/diff/
> 
> 
> Testing
> -------
> 
> Did manual testing.
> 
> 
> Thanks,
> 
> bharat kumar
> 
>