You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2018/01/18 21:42:28 UTC
kudu git commit: Enable vptr UBSAN checker
Repository: kudu
Updated Branches:
refs/heads/master 04af620c3 -> 918db2d66
Enable vptr UBSAN checker
The issue with boost intrusive list no longer appears to be relevant. If
it reappears we can add the corresponding functions to the UBSAN
blacklist instead of disabling the check across the board.
Change-Id: I2ce8631964292aec4d7be56577f5a6ef3b596cbd
Reviewed-on: http://gerrit.cloudera.org:8080/9051
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/918db2d6
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/918db2d6
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/918db2d6
Branch: refs/heads/master
Commit: 918db2d667b8722d906801dcf4980bcd939f0eba
Parents: 04af620
Author: Dan Burkert <da...@danburkert.com>
Authored: Wed Jan 17 20:18:01 2018 -0800
Committer: Dan Burkert <da...@cloudera.com>
Committed: Thu Jan 18 21:41:35 2018 +0000
----------------------------------------------------------------------
CMakeLists.txt | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/918db2d6/CMakeLists.txt
----------------------------------------------------------------------
diff --git a/CMakeLists.txt b/CMakeLists.txt
index cf9530b..1faab2d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -350,9 +350,8 @@ if (${KUDU_USE_UBSAN})
endif()
# Enable UB and unsigned integer overflow detection.
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined,integer")
- # Disable 'vptr' because it currently crashes somewhere in boost::intrusive::list code
# Disable 'alignment' because unaligned access is really OK on Nehalem and we do it all over the place.
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize=alignment,vptr")
+ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize=alignment")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize-blacklist=${CMAKE_CURRENT_SOURCE_DIR}/build-support/ubsan-blacklist.txt")
# Stop execution after UB or overflow is detected.
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover")