You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/11/03 15:27:15 UTC

[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #355: chore: improve hugegraph-client ut & stabilize hugegraph-client-ci

javeme commented on code in PR #355:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/355#discussion_r1013055234


##########
hugegraph-client/src/test/java/com/baidu/hugegraph/testutil/Utils.java:
##########
@@ -318,4 +318,9 @@ public static String formatDate(String date) {
     public static String formatDate(Date date) {
         return DATE_FORMAT.format(date);
     }
+
+    public static void AssertTime(Date createTime) {

Review Comment:
   rename to assertBeforeNow()?



##########
hugegraph-client/src/test/java/com/baidu/hugegraph/api/EdgeLabelApiTest.java:
##########
@@ -19,6 +19,8 @@
 
 package com.baidu.hugegraph.api;
 
+import static com.baidu.hugegraph.testutil.Utils.AssertTime;

Review Comment:
   according to our style, prefer to import com.baidu.hugegraph.testutil.Utils then use Utils.xx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org