You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/12 14:35:46 UTC

[GitHub] [airflow] dimberman commented on a change in pull request #14709: Refactor Taskflow decorator for extensibility

dimberman commented on a change in pull request #14709:
URL: https://github.com/apache/airflow/pull/14709#discussion_r593217987



##########
File path: airflow/decorators/__init__.py
##########
@@ -0,0 +1,66 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import warnings
+from typing import Callable, Optional
+
+from airflow.decorators.python import python_task
+from airflow.models.dag import dag  # noqa # pylint: disable=unused-import
+
+
+class _TaskDecorator:
+    def __call__(
+        self, python_callable: Optional[Callable] = None, multiple_outputs: Optional[bool] = None, **kwargs
+    ):
+        """
+        Deprecated function that calls @task.python and allows users to turn a python function into
+        an Airflow task.
+        @param python_callable:
+        @param multiple_outputs:
+        @param kwargs:
+        @return:
+        """
+        warnings.warn(
+            """Calling airflow.decorators.task for python tasks is deprecated.
+            Please use @task.python instead.
+            Example:
+
+            from airflow.decorators import task
+            @task.python
+            def my_task()""",
+            DeprecationWarning,
+            stacklevel=2,
+        )
+        return task.python(python_callable=python_callable, multiple_outputs=multiple_outputs, **kwargs)
+
+    @staticmethod
+    def python(python_callable: Optional[Callable] = None, multiple_outputs: Optional[bool] = None, **kwargs):
+        """
+        Python operator decorator. Wraps a function into an Airflow operator.
+        Accepts kwargs for operator kwarg. Can be reused in a single DAG.

Review comment:
       What's the difference?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org