You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "njnu-seafish (via GitHub)" <gi...@apache.org> on 2026/02/06 03:38:33 UTC
[PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
njnu-seafish opened a new pull request, #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
close #17960
## Brief change log
Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contains incompatible change, you should also add it to `docs/docs/en/guide/upgrade/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#discussion_r2939744664
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/validator/GlobalParamsValidator.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.api.validator;
+
+import org.apache.dolphinscheduler.plugin.task.api.model.Property;
+import org.apache.dolphinscheduler.plugin.task.api.utils.GlobalParameterUtils;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.springframework.stereotype.Component;
+
+/**
+ * Validates global parameters: non-empty keys, no duplicates
+ * <p> If globalParams is not valid, an {@link IllegalArgumentException} will be thrown. </p>
+ */
+@Slf4j
+@Component
+public class GlobalParamsValidator implements IValidator<String> {
+
+ @Override
+ public void validate(String globalParams) {
+ if (StringUtils.isBlank(globalParams)) {
+ return;
+ }
+
+ List<Property> params;
+ try {
+ params = GlobalParameterUtils.deserializeGlobalParameter(globalParams);
+ } catch (Exception e) {
+ throw new IllegalArgumentException("Invalid globalParams");
Review Comment:
```suggestion
throw new IllegalArgumentException("Invalid globalParams", e);
```
Don't eat the exception.
##########
dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/utils/GlobalParameterUtils.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.plugin.task.api.utils;
+
+import org.apache.dolphinscheduler.common.utils.JSONUtils;
+import org.apache.dolphinscheduler.plugin.task.api.model.Property;
+
+import org.apache.commons.collections4.CollectionUtils;
+
+import java.util.List;
+
+import lombok.experimental.UtilityClass;
+import lombok.extern.slf4j.Slf4j;
+
+@Slf4j
+@UtilityClass
+public class GlobalParameterUtils {
+
+ public String serializeGlobalParameter(List<Property> globalParams) {
+ if (CollectionUtils.isEmpty(globalParams)) {
+ return null;
+ }
+ return JSONUtils.toJsonString(globalParams);
+ }
+
+ public List<Property> deserializeGlobalParameter(String globalParams) {
+ return JSONUtils.toList(globalParams, Property.class);
Review Comment:
```suggestion
return JSONUtils.parseObject(globalParams, new TypeReference<List<Property>{});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#discussion_r2774620830
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -291,6 +292,15 @@ public Map<String, Object> createWorkflowDefinition(User loginUser,
definition.getName(), definition.getCode());
throw new ServiceException(Status.WORKFLOW_DEFINITION_NAME_EXIST, name);
}
+
+ try {
+ validateGlobalParams(globalParams);
+ } catch (ServiceException ex) {
+ log.warn("Invalid globalParams: {}", ex.getMessage());
+ putMsg(result, Status.REQUEST_PARAMS_NOT_VALID_ERROR, ex.getMessage());
+ return result;
+ }
Review Comment:
```suggestion
validateGlobalParams(globalParams);
```
Directly throw `ServiceException` at `validateGlobalParams`, please don't use a lot of try catch here.
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -847,6 +866,42 @@ public Map<String, Object> updateWorkflowDefinition(User loginUser,
return result;
}
+ /**
+ * Validates global parameters: non-empty keys, no duplicates, and required values for IN-type params.
+ */
+ private void validateGlobalParams(String globalParams) {
Review Comment:
We shouldn't be writing this kind of glue code everywhere. Why not use a GlobalParamValidator to handle this task?
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -847,6 +866,42 @@ public Map<String, Object> updateWorkflowDefinition(User loginUser,
return result;
}
+ /**
+ * Validates global parameters: non-empty keys, no duplicates, and required values for IN-type params.
+ */
+ private void validateGlobalParams(String globalParams) {
+ if (StringUtils.isBlank(globalParams)) {
+ return;
+ }
+
+ List<Property> params;
+ try {
+ params = JSONUtils.toList(globalParams, Property.class);
+ } catch (Exception e) {
+ throw new ServiceException("Invalid globalParams");
+ }
+
+ if (params == null || params.isEmpty()) {
+ return;
+ }
+
+ Set<String> keys = new HashSet<>();
+ for (Property p : params) {
+ if (StringUtils.isEmpty(p.getProp())) {
+ throw new ServiceException("Global param key cannot be empty");
+ }
+
+ String key = p.getProp().trim();
+ if (!keys.add(key)) {
+ throw new ServiceException("Duplicate global param key: " + key);
+ }
+
+ if (Direct.IN.equals(p.getDirect()) && StringUtils.isEmpty(p.getValue())) {
+ throw new ServiceException("IN param value required for key: " + key);
+ }
Review Comment:
We should support the value to be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4001935193
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate failed**
Failed conditions
 [12.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4001938703
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate failed**
Failed conditions
 [12.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list) (required ≥ 60%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4036918691
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [93.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4067498153
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [89.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4067483665
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [89.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#discussion_r2916126119
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/validator/GlobalParamsValidator.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dolphinscheduler.api.validator;
+
+import org.apache.dolphinscheduler.common.utils.JSONUtils;
+import org.apache.dolphinscheduler.plugin.task.api.model.Property;
+
+import org.apache.commons.lang3.StringUtils;
+
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import lombok.extern.slf4j.Slf4j;
+
+import org.springframework.stereotype.Component;
+
+/**
+ * Validates global parameters: non-empty keys, no duplicates
+ * <p> If globalParams is not valid, an {@link IllegalArgumentException} will be thrown. </p>
+ */
+@Slf4j
+@Component
+public class GlobalParamsValidator implements IValidator<String> {
+
+ @Override
+ public void validate(String globalParams) {
+ if (StringUtils.isBlank(globalParams)) {
+ return;
+ }
+
+ List<Property> params;
+ try {
+ params = JSONUtils.toList(globalParams, Property.class);
+ } catch (Exception e) {
+ throw new IllegalArgumentException("Invalid globalParams");
+ }
Review Comment:
Add `GlobalParameterUtils` and add `serialize` `deserialize` method just like `VarPoolUtils`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "njnu-seafish (via GitHub)" <gi...@apache.org>.
njnu-seafish commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4053077606
@ruanwenjun @SbloodyS Could you please help review and merge this PR? It has been open for quite some time, and I currently need to keep pushing updates just to trigger the CI pipeline. Your assistance would be greatly appreciated.
<img width="1204" height="669" alt="企业微信截图_1773382832513" src="https://github.com/user-attachments/assets/81ff97d5-c92f-4f1f-858b-fa45a9e1f4a8" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "njnu-seafish (via GitHub)" <gi...@apache.org>.
njnu-seafish commented on code in PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#discussion_r2875719811
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/WorkflowDefinitionServiceImpl.java:
##########
@@ -291,6 +292,15 @@ public Map<String, Object> createWorkflowDefinition(User loginUser,
definition.getName(), definition.getCode());
throw new ServiceException(Status.WORKFLOW_DEFINITION_NAME_EXIST, name);
}
+
+ try {
+ validateGlobalParams(globalParams);
+ } catch (ServiceException ex) {
+ log.warn("Invalid globalParams: {}", ex.getMessage());
+ putMsg(result, Status.REQUEST_PARAMS_NOT_VALID_ERROR, ex.getMessage());
+ return result;
+ }
Review Comment:
> Suggested change
> try {
> validateGlobalParams(globalParams);
> } catch (ServiceException ex) {
> log.warn("Invalid globalParams: {}", ex.getMessage());
> putMsg(result, Status.REQUEST_PARAMS_NOT_VALID_ERROR, ex.getMessage());
> return result;
> }
> validateGlobalParams(globalParams);
> Directly throw `ServiceException` at `validateGlobalParams`, please don't use a lot of try catch here.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4073700089
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [83.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4073076942
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [83.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4036920682
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [1 New issue](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [93.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4073071475
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [83.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4073684099
## [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961) **Quality Gate passed**
Issues
 [3 New issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=17961&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [83.9% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=17961&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=17961)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Improvement-17960][API]Add null/empty/duplicate validation logic for globalParams when creating or updating a workflow [dolphinscheduler]
Posted by "njnu-seafish (via GitHub)" <gi...@apache.org>.
njnu-seafish commented on PR #17961:
URL: https://github.com/apache/dolphinscheduler/pull/17961#issuecomment-4012415636
Hey @ruanwenjun @SbloodyS, whenever you have time, would you mind reviewing this fix? Really thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org