[GitHub] [systemds-website] j143 commented on a change in pull request #71: [SYSTEMDS-???] Main Webpage Update to SystemDS

[GitBox <gi...@apache.org>]

j143 commented on a change in pull request #71:
URL: https://github.com/apache/systemds-website/pull/71#discussion_r454782978



##########
File path: gulpfile.js
##########
@@ -19,7 +19,8 @@ const config = {
       '_src/_scripts/jquery-2.1.1.min.js',
       '_src/_scripts/jquery.fitvids.js',
       '_src/_scripts/ap-components.min.js',
-      '_src/_scripts/main.js'
+      '_src/_scripts/main.js',

Review comment:
       Comment 1: Let us create a different PR for this.

##########
File path: _src/tutorial-kdd2017.html
##########
@@ -1,50 +0,0 @@
----

Review comment:
       Comment 3: Another PR, for removing the tutorials.

##########
File path: _src/assets/js/jquery-1.12.4.min.js
##########
@@ -1,5 +0,0 @@
-/*! jQuery v1.12.4 | (c) jQuery Foundation | jquery.org/license */

Review comment:
       Comment 4: These redundant jquery files can be done in another PR/commit.

##########
File path: package-lock.json
##########
@@ -1,6 +1,6 @@
 {
-  "name": "systemml-website",
-  "version": "0.1.0",
+  "name": "systemds-website",

Review comment:
       Comment 2: This is out of scope of this PR. These changes will be taken up in a different PR.
   same with `package.json` file.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org