You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by alopresto <gi...@git.apache.org> on 2016/07/08 22:46:05 UTC
[GitHub] nifi pull request #622: NIFI-2186 Refactored CertificateUtils to separate lo...
GitHub user alopresto opened a pull request:
https://github.com/apache/nifi/pull/622
NIFI-2186 Refactored CertificateUtils to separate logic for DN extrac\u2026
\u2026tion from server/client sockets. Added logic to detect server/client mode encapsulated in exposed method.
Added unit tests for DN extraction.
Corrected typo in Javadoc.
Switched server/client socket logic for certificate extraction -- when the local socket is in client/server mode, the peer is necessarily the inverse.
Fixed unit tests.
Moved lazy-loading authentication access out of isDebugEnabled() control branch.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alopresto/nifi NIFI-2186
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/622.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #622
----
commit b6fec77ccab01664a11518b6f9652bc2cd855040
Author: Andy LoPresto <al...@apache.org>
Date: 2016-07-05T04:05:58Z
NIFI-2186 Refactored CertificateUtils to separate logic for DN extraction from server/client sockets. Added logic to detect server/client mode encapsulated in exposed method.
Added unit tests for DN extraction.
Corrected typo in Javadoc.
Switched server/client socket logic for certificate extraction -- when the local socket is in client/server mode, the peer is necessarily the inverse.
Fixed unit tests.
Moved lazy-loading authentication access out of isDebugEnabled() control branch.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #622: NIFI-2186 Refactored CertificateUtils to separate logic for...
Posted by mcgilman <gi...@git.apache.org>.
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/622
Looks good @alopresto! Thanks, this has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #622: NIFI-2186 Refactored CertificateUtils to separate logic for...
Posted by alopresto <gi...@git.apache.org>.
Github user alopresto commented on the issue:
https://github.com/apache/nifi/pull/622
This is the fix that was included in `0.7.0` in [https://github.com/apache/nifi/pull/611](PR 611) for [https://issues.apache.org/jira/browse/NIFI-2119](NIFI-2119).
I have tested this on a secured `1.0` cluster (2 nodes, one running embedded Zookeeper). I exercised the cluster with `nifi.security.needClientAuth` set to both *true* and *false*.
Setting up a ZMC cluster is not fully documented yet as there is still on-going work, so if anyone reviewing this needs example keystores and configuration files to get the cluster running, let me know.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #622: NIFI-2186 Refactored CertificateUtils to separate lo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/622
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---