You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/22 21:34:19 UTC
[jira] [Commented] (CB-10668) move node_modules to package.json and
update create script to copy from root
[ https://issues.apache.org/jira/browse/CB-10668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157653#comment-15157653 ]
ASF GitHub Bot commented on CB-10668:
-------------------------------------
GitHub user stevengill opened a pull request:
https://github.com/apache/cordova-osx/pull/33
CB-10668 Moved node_modules to root
* Added dependencies to `package.json`
* Added `bundledDependencies` to `package.json`
* Updated `prepare.js` to use `ios_CFBundleVersion` and `ios_CFBundleIdentifier` instead of `osx_` prefix because those don't exist in `cordova-common` yet
* Updated `create.js` to grab `node_modules` from root instead of `bin/node_modules`
* Deleted `bin/node_modules`
* Updated iOS references to OSX where applicable (API.js and prepare.js)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stevengill/cordova-osx master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-osx/pull/33.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #33
----
commit 249f7dd2bcb3388f0d6679f037f5c5e9dc5e9daf
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T18:53:02Z
CB-10668 updated package.json, prepare.js and Api.js
commit 103deecb1e7295a9a96e24000591354023d30eee
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T18:53:26Z
CB-10668 removed bin/node_modules, updated create.js to use root
node_modules
commit 7a58a67bee7576155b5c369124c7bced51c82fec
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T19:55:25Z
CB-10668 added node_modules directory
commit 18df1bfcea10fd67f130de9d017e23f4cd1cc307
Author: Steve Gill <st...@gmail.com>
Date: 2016-02-22T20:29:05Z
CB-10668 fixed failing tests, reverted shelljs to 0.5.3
----
> move node_modules to package.json and update create script to copy from root
> ----------------------------------------------------------------------------
>
> Key: CB-10668
> URL: https://issues.apache.org/jira/browse/CB-10668
> Project: Apache Cordova
> Issue Type: Improvement
> Components: iOS, OSX
> Reporter: Steve Gill
> Assignee: Steve Gill
>
> Right now, node_modules lives in cordova-ios/bin/node_modules. That means we aren't managing those deps anywhere (not in package.json). I propose moving these into the root package.json and adding them as bundledDependenceis. Then update the create script to copy the root/node_modules directory instead of root/bin/node_modules.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org