You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by "kezhenxu94 (via GitHub)" <gi...@apache.org> on 2023/06/30 07:51:16 UTC

[GitHub] [skywalking] kezhenxu94 commented on pull request #10990: fix: Limit the length of Event#parameters(#10263)

kezhenxu94 commented on PR #10990:
URL: https://github.com/apache/skywalking/pull/10990#issuecomment-1614271016

   > @kezhenxu94 I also want to push a little back about this fix. What do you think we make this longer, than in the storage level, it would be a `text` rather than a varchar. Considering `storageOnly = true`, it should be harmless. Then we don't need this fix, but a type change only.
   
   Changing the type of Event#parameters is good for ElasticSearch storage, but for JDBC storage it seems to have no effect.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org