You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2015/10/14 20:14:32 UTC
Review Request 39323: Fixed syntax error in sed usage on OSX.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/
-----------------------------------------------------------
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-3734
https://issues.apache.org/jira/browse/MESOS-3734
Repository: mesos
Description
-------
5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
OSX. Apparently there is not a portable way to instruct sed not to make a backup
file; hence, we know create a backup file and then immediately delete it.
Diffs
-----
src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
Diff: https://reviews.apache.org/r/39323/diff/
Testing
-------
Successfully built on OSX.
Thanks,
Neil Conway
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102694
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39323]
All tests passed.
- Mesos ReviewBot
On Oct. 14, 2015, 6:26 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:26 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102705
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Oct. 14, 2015, 6:26 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:26 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Gilbert Song <gi...@mesoshere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102709
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Oct. 14, 2015, 11:26 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 11:26 a.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Neil Conway <ne...@gmail.com>.
> On Oct. 14, 2015, 11:24 p.m., James Peach wrote:
> > Automake detects sed, so I think that you should do something like this:
> >
> > SED_I = $(SED) -i.orig
> >
> > foo: bar
> > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@
I suppose there's value in using $(SED) instead of "sed". Using $(AM_V_GEN) when running some commands but not others (e.g., protoc) seems inconsistent to me, though.
I'm inclined to replace "sed" with $(SED) and leave it at that (since it would be nice to unbreak the build); we can consider further cleanup separately.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102718
-----------------------------------------------------------
On Oct. 14, 2015, 6:26 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:26 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by James Peach <jp...@apache.org>.
> On Oct. 14, 2015, 11:24 p.m., James Peach wrote:
> > Automake detects sed, so I think that you should do something like this:
> >
> > SED_I = $(SED) -i.orig
> >
> > foo: bar
> > $(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@
>
> Neil Conway wrote:
> I suppose there's value in using $(SED) instead of "sed". Using $(AM_V_GEN) when running some commands but not others (e.g., protoc) seems inconsistent to me, though.
>
> I'm inclined to replace "sed" with $(SED) and leave it at that (since it would be nice to unbreak the build); we can consider further cleanup separately.
That's fair enough. Just for fun, here's a diff with pretty PROTOC output http://fpaste.org/279307/48670631/ :)
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102718
-----------------------------------------------------------
On Oct. 14, 2015, 11:41 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102718
-----------------------------------------------------------
Automake detects sed, so I think that you should do something like this:
SED_I = $(SED) -i.orig
foo: bar
$(AM_V_GEN)$(SED_I) 's/mesos.mesos_pb2/mesos_pb2/' $@
- James Peach
On Oct. 14, 2015, 6:26 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:26 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102744
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39323]
All tests passed.
- Mesos ReviewBot
On Oct. 14, 2015, 11:41 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102727
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Oct. 14, 2015, 11:41 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102726
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Oct. 14, 2015, 11:41 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 11:41 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we now create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/
-----------------------------------------------------------
(Updated Oct. 14, 2015, 11:41 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Replace "sed" with $(SED)
Bugs: MESOS-3734
https://issues.apache.org/jira/browse/MESOS-3734
Repository: mesos
Description
-------
5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
OSX. Apparently there is not a portable way to instruct sed not to make a backup
file; hence, we now create a backup file and then immediately delete it.
Diffs (updated)
-----
src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
Diff: https://reviews.apache.org/r/39323/diff/
Testing
-------
Successfully built on OSX.
Thanks,
Neil Conway
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/
-----------------------------------------------------------
(Updated Oct. 14, 2015, 6:26 p.m.)
Review request for mesos and Joris Van Remoortere.
Bugs: MESOS-3734
https://issues.apache.org/jira/browse/MESOS-3734
Repository: mesos
Description (updated)
-------
5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
OSX. Apparently there is not a portable way to instruct sed not to make a backup
file; hence, we now create a backup file and then immediately delete it.
Diffs
-----
src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
Diff: https://reviews.apache.org/r/39323/diff/
Testing
-------
Successfully built on OSX.
Thanks,
Neil Conway
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/
-----------------------------------------------------------
(Updated Oct. 14, 2015, 6:25 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Fix typo
Bugs: MESOS-3734
https://issues.apache.org/jira/browse/MESOS-3734
Repository: mesos
Description
-------
5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
OSX. Apparently there is not a portable way to instruct sed not to make a backup
file; hence, we know create a backup file and then immediately delete it.
Diffs (updated)
-----
src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
Diff: https://reviews.apache.org/r/39323/diff/
Testing
-------
Successfully built on OSX.
Thanks,
Neil Conway
Re: Review Request 39323: Fixed syntax error in sed usage on OSX.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39323/#review102677
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On Oct. 14, 2015, 6:14 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39323/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2015, 6:14 p.m.)
>
>
> Review request for mesos and Joris Van Remoortere.
>
>
> Bugs: MESOS-3734
> https://issues.apache.org/jira/browse/MESOS-3734
>
>
> Repository: mesos
>
>
> Description
> -------
>
> 5d246ce4e2d40b adopted sed syntax that works on Linux but does not work on
> OSX. Apparently there is not a portable way to instruct sed not to make a backup
> file; hence, we know create a backup file and then immediately delete it.
>
>
> Diffs
> -----
>
> src/Makefile.am 2bf40f27733b4362d64679bf594e15e82f47155d
>
> Diff: https://reviews.apache.org/r/39323/diff/
>
>
> Testing
> -------
>
> Successfully built on OSX.
>
>
> Thanks,
>
> Neil Conway
>
>