You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/05/01 01:52:26 UTC
Re: Review Request: Updated Group and Group::Membership API.
> On 2012-04-24 21:32:34, Vinod Kone wrote:
> > src/zookeeper/group.cpp, line 458
> > <https://reviews.apache.org/r/4844/diff/2/?file=104002#file104002line458>
> >
> > consider foreachpair
Done.
> On 2012-04-24 21:32:34, Vinod Kone wrote:
> > src/zookeeper/group.cpp, line 468
> > <https://reviews.apache.org/r/4844/diff/2/?file=104002#file104002line468>
> >
> > s/onowned/unowned/
Done.
> On 2012-04-24 21:32:34, Vinod Kone wrote:
> > src/zookeeper/group.cpp, line 585
> > <https://reviews.apache.org/r/4844/diff/2/?file=104002#file104002line585>
> >
> > should this be == 1?
Yes, I like the explicitness.
> On 2012-04-24 21:32:34, Vinod Kone wrote:
> > src/zookeeper/group.cpp, line 672
> > <https://reviews.apache.org/r/4844/diff/2/?file=104002#file104002line672>
> >
> > consider foreachpair here and below
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4844/#review7189
-----------------------------------------------------------
On 2012-04-23 18:49:26, Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4844/
> -----------------------------------------------------------
>
> (Updated 2012-04-23 18:49:26)
>
>
> Review request for mesos, John Sirois and Vinod Kone.
>
>
> Summary
> -------
>
> (1) Renamed Group::info to Group::data (and associated changes).
> (2) Added Group::Membership::watch to explicitly watch for a single membership's cancellation (and associated GroupProcess changes).
> (3) Fixed a but in GroupProcess::update that was deleting a Watch object when also re-enqueueing it.
> (4) Updated the GroupProcess destructor to fail all outstanding futures associated with the Group.
>
>
> Diffs
> -----
>
> src/log/network.hpp 0f7fefd
> src/tests/zookeeper_tests.cpp a852103
> src/zookeeper/group.hpp 695a8ab
> src/zookeeper/group.cpp c9122f6
>
> Diff: https://reviews.apache.org/r/4844/diff
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin
>
>