You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/27 06:13:02 UTC
[GitHub] [doris] HappenLee opened a new pull request, #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
HappenLee opened a new pull request, #10447:
URL: https://github.com/apache/doris/pull/10447
# Proposed changes
Issue Number: close #xxx
## Problem Summary:
After do the opt of this
unique_table 1000W data load time
before:45s -> after:35s
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on PR #10447:
URL: https://github.com/apache/doris/pull/10447#issuecomment-1169935599
Hi, please rebase the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10447:
URL: https://github.com/apache/doris/pull/10447#issuecomment-1179735244
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10447:
URL: https://github.com/apache/doris/pull/10447#issuecomment-1179735243
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt merged pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt merged PR #10447:
URL: https://github.com/apache/doris/pull/10447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #10447:
URL: https://github.com/apache/doris/pull/10447#discussion_r907017079
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -210,26 +210,30 @@ class WindowFunctionNTile final
struct Value {
public:
bool is_null() const { return _is_null; }
- StringRef get_value() const { return _value; }
-
void set_null(bool is_null) { _is_null = is_null; }
- void set_value(StringRef value) { _value = value; }
+ StringRef get_value() const { return _ptr->get_data_at(_offset); }
+
+ void set_value(StringRef ref) {
Review Comment:
Whether use `StringRef` to represent column_ptr and offset is too tricky?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #10447:
URL: https://github.com/apache/doris/pull/10447#discussion_r907022691
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -262,58 +266,31 @@ struct LeadAndLagData {
col.insert_default();
Review Comment:
just for reduce one time `virtual function call`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on a diff in pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
HappenLee commented on code in PR #10447:
URL: https://github.com/apache/doris/pull/10447#discussion_r907020817
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -210,26 +210,30 @@ class WindowFunctionNTile final
struct Value {
public:
bool is_null() const { return _is_null; }
- StringRef get_value() const { return _value; }
-
void set_null(bool is_null) { _is_null = is_null; }
- void set_value(StringRef value) { _value = value; }
+ StringRef get_value() const { return _ptr->get_data_at(_offset); }
+
+ void set_value(StringRef ref) {
Review Comment:
just keep same with `copy_value` do make sure the interface is same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #10447: [Load][Vectorized] load opt code by change `replace` and `replace_if_not_null` do not copy value
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on code in PR #10447:
URL: https://github.com/apache/doris/pull/10447#discussion_r907014191
##########
be/src/vec/aggregate_functions/aggregate_function_window.h:
##########
@@ -262,58 +266,31 @@ struct LeadAndLagData {
col.insert_default();
Review Comment:
Maybe we can sympfy this function to two case `is_null` or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org