[GitHub] [spark] HyukjinKwon commented on a change in pull request #29917: [SPARK-33040][R][ML] Add SparkR wrapper for vector_to_array

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #29917:
URL: https://github.com/apache/spark/pull/29917#discussion_r499340061



##########
File path: R/pkg/tests/fulltests/test_sparkSQL.R
##########
@@ -1424,7 +1424,8 @@ test_that("column functions", {
     date_trunc("quarter", c) + current_date() + current_timestamp()
   c25 <- overlay(c1, c2, c3, c3) + overlay(c1, c2, c3) + overlay(c1, c2, 1) +
     overlay(c1, c2, 3, 4)
-  c26 <- timestamp_seconds(c1)
+  c26 <- timestamp_seconds(c1) + vector_to_array(c) +
+    vector_to_array(c, "float32") + vector_to_array(c, "float64")

Review comment:
       quick question @zero323. why did we don't do the default argument here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org