You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by "RomanKa (Jira)" <ji...@apache.org> on 2019/12/17 20:33:00 UTC
[jira] [Created] (TOMEE-2756) Typo in the DeploymentsResolver
causes excluding all URLs
RomanKa created TOMEE-2756:
------------------------------
Summary: Typo in the DeploymentsResolver causes excluding all URLs
Key: TOMEE-2756
URL: https://issues.apache.org/jira/browse/TOMEE-2756
Project: TomEE
Issue Type: Bug
Components: TomEE Core Server
Affects Versions: 7.0.5
Environment: Ubuntu 18.04, Embedded TomEE 7.0.5 (but problem is on all platforms)
Reporter: RomanKa
In the project: openejb-core
Is in the package: org.apache.openejb.config
Class: DeploymentsResolver
Method: loadFromClasspath
Line: 264
There is typo there from refactoring done 5 years ago, which prevent us from upgrading.
Current code:
{code:java}
UrlSet unchecked = new UrlSet(); if (!searchResult.filterDescriptors) {
unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.prefiltered));
if (searchResult.filterSystemApps) {
unchecked = unchecked.exclude(".*/openejb-[^/]+(.(jar|ear|war)(./)?|/target/classes/?)");
}
processUrls("DeploymentsResolver2", unchecked.getUrls(), classLoader, EnumSet.allOf(RequireDescriptors.class), jarList);
} {code}
In the exclude should be urlSet instead of prefiltered, otherwice all URL are excluded:
{code:java}
unchecked = NewLoaderLogic.applyBuiltinExcludes(searchResult.prefiltered.exclude(searchResult.urlSet));
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)