You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/27 09:59:44 UTC

[GitHub] [arrow-rs] liukun4515 opened a new issue #1098: support i128 as the ArrowNativeType

liukun4515 opened a new issue #1098:
URL: https://github.com/apache/arrow-rs/issues/1098


   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   when I implement the comparison operation for decimal data type, I should support `i128` for https://github.com/apache/arrow-rs/blob/8b85aa03d2c2af1cfa81f03a2ab2457d21d02f93/arrow/src/buffer/mutable.rs#L301 this function.
   
   In the pr https://github.com/apache/arrow-rs/pull/779, The `i128` has been added as ArrowNativeType, but this is `change-api` changes.
   
   how should i continue this work?
   
   @alamb 
   Can I cherry-pick part code of this https://github.com/apache/arrow-rs/pull/779 to `release branch`？
   
   
   **Describe the solution you'd like**
   A clear and concise description of what you want to happen.
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   Add any other context or screenshots about the feature request here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] liukun4515 removed a comment on issue #1098: support i128 as the ArrowNativeType

Posted by GitBox <gi...@apache.org>.
liukun4515 removed a comment on issue #1098:
URL: https://github.com/apache/arrow-rs/issues/1098#issuecomment-1002102916


   > 
   
   Thanks for your feedback.
   
   Now we use `i128 to u8 slice` to represent the decimal value, and we use the FixedsizeListBuilder to append decimal value. If the i128 is as the ArraowNativeType, maybe we can change it to the Int128Builder to append decimal value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] liukun4515 commented on issue #1098: support i128 as the ArrowNativeType

Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1098:
URL: https://github.com/apache/arrow-rs/issues/1098#issuecomment-1002102916


   > 
   
   Thanks for your feedback.
   
   Now we use `i128 to u8 slice` to represent the decimal value, and we use the FixedsizeListBuilder to append decimal value. If the i128 is as the ArraowNativeType, maybe we can change it to the Int128Builder to append decimal value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #1098: support i128 as the ArrowNativeType

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1098:
URL: https://github.com/apache/arrow-rs/issues/1098#issuecomment-1002019488


   I think back porting just the `impl ArrowNativeType for i128` is a reasonable thing to do for the release branch. 
   
   The main reason it has the `api-change` label is that it adds a new `enum` variant for `IntervalUnit`
   
   However, I expect that arrow 6.5.0 will be the last release created before the release of 7.0.0 (which I expect in 2 weeks time)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb closed issue #1098: support i128 as the ArrowNativeType

Posted by GitBox <gi...@apache.org>.
alamb closed issue #1098:
URL: https://github.com/apache/arrow-rs/issues/1098


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #1098: support i128 as the ArrowNativeType

Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1098:
URL: https://github.com/apache/arrow-rs/issues/1098#issuecomment-1018752770


   I believe this is now complete: https://sourcegraph.com/github.com/apache/arrow-rs/-/blob/arrow/src/datatypes/native.rs?L220-241&subtree=true


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] liukun4515 commented on issue #1098: support i128 as the ArrowNativeType

Posted by GitBox <gi...@apache.org>.
liukun4515 commented on issue #1098:
URL: https://github.com/apache/arrow-rs/issues/1098#issuecomment-1002103229


   > I think back porting just the `impl ArrowNativeType for i128` is a reasonable thing to do for the release branch.
   > 
   > The main reason it has the `api-change` label is that it adds a new `enum` variant for `IntervalUnit`
   > 
   > However, I expect that arrow 6.5.0 will be the last release created before the release of 7.0.0 (which I expect in 2 weeks time)
   
   Thanks for your feedback.
   
   Now we use `i128 to u8 slice` to represent the decimal value, and we use the FixedsizeListBuilder to append decimal value. If the i128 is as the ArraowNativeType, maybe we can change it to the Int128Builder to append decimal value.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org