You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/21 09:17:14 UTC
[GitHub] [dubbo-go] cvictory opened a new pull request #950: Feature: Add ParameterTypeNames at Invocation
cvictory opened a new pull request #950:
URL: https://github.com/apache/dubbo-go/pull/950
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
Add ParameterTypeNames at Invocation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #950: Feature: Add ParameterTypeNames at Invocation
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #950:
URL: https://github.com/apache/dubbo-go/pull/950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #950: Feature: Add ParameterTypeNames at Invocation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #950:
URL: https://github.com/apache/dubbo-go/pull/950#issuecomment-749317100
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=h1) Report
> Merging [#950](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=desc) (766c2ca) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #950 +/- ##
===========================================
+ Coverage 60.20% 60.33% +0.12%
===========================================
Files 260 260
Lines 12886 12894 +8
===========================================
+ Hits 7758 7779 +21
+ Misses 4170 4151 -19
- Partials 958 964 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `69.04% <0.00%> (-1.12%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `61.60% <0.00%> (+1.98%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=footer). Last update [04fa9b0...766c2ca](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #950: Feature: Add ParameterTypeNames at Invocation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #950:
URL: https://github.com/apache/dubbo-go/pull/950#issuecomment-749317100
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=h1) Report
> Merging [#950](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=desc) (0ecbcef) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **decrease** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #950 +/- ##
===========================================
- Coverage 60.20% 60.04% -0.17%
===========================================
Files 260 260
Lines 12886 12894 +8
===========================================
- Hits 7758 7742 -16
- Misses 4170 4191 +21
- Partials 958 961 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `52.77% <0.00%> (-8.34%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `46.12% <0.00%> (-5.31%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `77.17% <0.00%> (-2.18%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `69.04% <0.00%> (-1.12%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `61.60% <0.00%> (+1.98%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=footer). Last update [04fa9b0...0ecbcef](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cvictory commented on a change in pull request #950: Feature: Add ParameterTypeNames at Invocation
Posted by GitBox <gi...@apache.org>.
cvictory commented on a change in pull request #950:
URL: https://github.com/apache/dubbo-go/pull/950#discussion_r547045201
##########
File path: protocol/invocation/rpcinvocation.go
##########
@@ -213,6 +221,13 @@ func WithParameterTypes(parameterTypes []reflect.Type) option {
}
}
+// WithParameterTypeNames creates option with @parameterTypeNames.
+func WithParameterTypeNames(parameterTypeNames []string) option {
+ return func(invo *RPCInvocation) {
+ invo.parameterTypeNames = parameterTypeNames
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #950: Feature: Add ParameterTypeNames at Invocation
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #950:
URL: https://github.com/apache/dubbo-go/pull/950#discussion_r546634808
##########
File path: protocol/invocation/rpcinvocation.go
##########
@@ -213,6 +221,13 @@ func WithParameterTypes(parameterTypes []reflect.Type) option {
}
}
+// WithParameterTypeNames creates option with @parameterTypeNames.
+func WithParameterTypeNames(parameterTypeNames []string) option {
+ return func(invo *RPCInvocation) {
+ invo.parameterTypeNames = parameterTypeNames
Review comment:
IMO, u'd better copy this parameterTypeNames.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io edited a comment on pull request #950: Feature: Add ParameterTypeNames at Invocation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #950:
URL: https://github.com/apache/dubbo-go/pull/950#issuecomment-749317100
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=h1) Report
> Merging [#950](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=desc) (766c2ca) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/04fa9b0e278af644393d30c7d9587abc482beca9?el=desc) (04fa9b0) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #950 +/- ##
===========================================
+ Coverage 60.20% 60.33% +0.12%
===========================================
Files 260 260
Lines 12886 12894 +8
===========================================
+ Hits 7758 7779 +21
+ Misses 4170 4151 -19
- Partials 958 964 +6
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (-3.16%)` | :arrow_down: |
| [cluster/router/chain/chain.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y2x1c3Rlci9yb3V0ZXIvY2hhaW4vY2hhaW4uZ28=) | `69.04% <0.00%> (-1.12%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `61.60% <0.00%> (+1.98%)` | :arrow_up: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `78.31% <0.00%> (+2.40%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/950/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `39.83% <0.00%> (+10.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=footer). Last update [04fa9b0...766c2ca](https://codecov.io/gh/apache/dubbo-go/pull/950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org