You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/09 11:28:03 UTC
[GitHub] [cordova-plugin-inappbrowser] mosabab opened a new pull request
#608: Update lefttoright info to correct information
mosabab opened a new pull request #608: Update lefttoright info to correct information
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/608
lefttoright option for android was written in wrong information.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
The current information regarding lefttoright option for android was written with wrong information, I changed the text to the correct information.
### Description
<!-- Describe your changes in detail -->
lefttoright information was written as:
lefttoright: Set to yes to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the left and close button to the right.
The correct information is:
lefttoright: Set to yes to swap positions of the navigation buttons and the close button. Specifically, navigation buttons go to the right and close button to the left.
### Testing
<!-- Please describe in detail how you tested your changes. -->
set lefttoright to yes to see what happen.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] mosabab closed pull request #608:
Update lefttoright info to correct information
Posted by GitBox <gi...@apache.org>.
mosabab closed pull request #608: Update lefttoright info to correct information
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org