Re: [PR] AVRO-3989: [java] add conversion classes to default instance of SpecificData [avro]

["opwvhk (via GitHub)" <gi...@apache.org>]

opwvhk commented on code in PR #3354:
URL: https://github.com/apache/avro/pull/3354#discussion_r2137890410


##########
lang/java/ipc/src/test/java/org/apache/avro/TestDataFileSpecific.java:
##########
@@ -70,4 +72,35 @@ void specificDatumReaderDefaultCtor() throws IOException {
     }
   }
 
+  @Test
+  public void testUnionWithLogicalType() throws IOException {
+    File file = new File(DIR.getPath(), "testSpecificDatumReaderDefaultCtorWithOptionalLogicalType");
+    Schema s1 = new Schema.Parser().parse("{\"type\":\"record\",\"name\":\"Bar\",\"namespace\":\"foo\","

Review Comment:
   Is there a specific reason to use duplicate the schema in this string? Or is it sufficient to read the schema from fooBar.avsc?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org