You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openmeetings.apache.org by GitBox <gi...@apache.org> on 2020/04/26 22:18:38 UTC

[GitHub] [openmeetings] sebawagner commented on a change in pull request #69: OPENMEETINGS-2307 Add checkstyle check with only checking for unused …

sebawagner commented on a change in pull request #69:
URL: https://github.com/apache/openmeetings/pull/69#discussion_r415413887



##########
File path: openmeetings-core/pom.xml
##########
@@ -32,6 +32,7 @@
 	<properties>
 		<site.basedir>${project.parent.basedir}</site.basedir>
 		<autoModuleName>apache.openmeetings.core</autoModuleName>
+		<checkstyle.config.location>${project.parent.basedir}/src/config/openmeetings_checkstyle.xml</checkstyle.config.location>

Review comment:
       Needs to overwrite config location inherited from parent. Parent can't configure ${project.parent.basedir} as config as it has no parent. Its the same problem like with site.basedir overwrite 2 lines above. I think this seems to work fine.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org