You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/03 23:54:17 UTC
[GitHub] [camel-k] nicolaferraro opened a new issue #1323: Cannot
append/override stored properties
nicolaferraro opened a new issue #1323: Cannot append/override stored properties
URL: https://github.com/apache/camel-k/issues/1323
After running an integration with e.g.
```
kamel run app.groovy -p a=1 --save
```
Then it's no longer possible to use properties:
```
kamel run app.groovy -p xxx=2
```
The same happens with dependencies.
In both cases, we should append properties/dependencies together.
We should also add some tests about this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] lburgazzoli commented on issue #1323: Cannot
append/override stored properties
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #1323: Cannot append/override stored properties
URL: https://github.com/apache/camel-k/issues/1323#issuecomment-594369478
I don't think this is possible with the libraries we use for the CLI as cobra + viper define a hierarchy where to find values for the flags which as today is:
- CLI flag
- environment
- file
So if you set something from the CLI with a flag, that flag overrides every value you may have eventually set through file or env var.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] lburgazzoli edited a comment on issue #1323: Cannot
append/override stored properties
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #1323: Cannot append/override stored properties
URL: https://github.com/apache/camel-k/issues/1323#issuecomment-594369478
I don't think this is possible with the libraries we use for the CLI as cobra + viper define a hierarchy where to find values for the flags which as today is:
1. CLI flag
2. environment
3. file
So if you set something from the CLI with a flag, that flag overrides every value you may have set through file or env var.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] lburgazzoli commented on issue #1323: Cannot
append/override stored properties
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #1323: Cannot append/override stored properties
URL: https://github.com/apache/camel-k/issues/1323#issuecomment-594388610
btw, I was thinking to replace _cobra + viper_ with https://github.com/urfave/cli as it has a lot less dependencies and looks simpler, at that point we can try to implement the _append_ behaviour but I would do it post 1.0 and document that the current set-up is about to set default values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] nicolaferraro commented on issue #1323: Cannot
append/override stored properties
Posted by GitBox <gi...@apache.org>.
nicolaferraro commented on issue #1323: Cannot append/override stored properties
URL: https://github.com/apache/camel-k/issues/1323#issuecomment-594394902
Agree, our current setting is a bit over-complicated.. and that CLI seems exactly what we need
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-k] lburgazzoli edited a comment on issue #1323: Cannot
append/override stored properties
Posted by GitBox <gi...@apache.org>.
lburgazzoli edited a comment on issue #1323: Cannot append/override stored properties
URL: https://github.com/apache/camel-k/issues/1323#issuecomment-594369478
I don't think this is possible with the libraries we use for the CLI as cobra + viper define a hierarchy where to find values for the flags which as today is:
1. CLI flag
2. environment
3. file
So if you set something from the CLI with a flag, that flag overrides every value you may have eventually set through file or env var.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services