You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by physikerwelt <gi...@git.apache.org> on 2014/10/19 14:19:12 UTC

[GitHub] incubator-flink pull request: [FLINK-1027] ignore invalid commandl...

GitHub user physikerwelt opened a pull request:

    https://github.com/apache/incubator-flink/pull/161

    [FLINK-1027] ignore invalid commandline options

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/physikerwelt/incubator-flink FLINK-1027

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-flink/pull/161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #161
    
----
commit fb3502d97f63131783d4848c8dd4696dbacc3d4a
Author: physikerwelt <wi...@physikerwelt.de>
Date:   2014-09-08T22:11:32Z

    [FLINK-1027] ignore invalid commandline options

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-1027] ignore invalid commandl...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/161#issuecomment-63636121
  
    Any comments here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-1027] ignore invalid commandl...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/161#issuecomment-63640387
  
    I think there may not be a test case for that. It would be great to add one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-1027] ignore invalid commandl...

Posted by physikerwelt <gi...@git.apache.org>.
Github user physikerwelt commented on the pull request:

    https://github.com/apache/incubator-flink/pull/161#issuecomment-63637522
  
    @StephanEwen is there a test case for that? If no... should we create one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-1027] ignore invalid commandl...

Posted by physikerwelt <gi...@git.apache.org>.
Github user physikerwelt commented on the pull request:

    https://github.com/apache/incubator-flink/pull/161#issuecomment-59648175
  
    @aalexandrov I'm not sure if that's what you had in mind. It solved the issues for @jimmyli97


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-flink pull request: [FLINK-1027] ignore invalid commandl...

Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:

    https://github.com/apache/incubator-flink/pull/161#issuecomment-60596192
  
    How does that affect using the trailing parameters as program arguments?
    
    Right now, you can call
    ```
    bin/flink run my_prog.jar parameter1 parameter2 parameter3
    ```
    
    Is that still possible after that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---