[GitHub] [nifi] bbende commented on issue #4170: NIFI-7294 Address deprecation issues in solrj and httpclient

[GitBox <gi...@apache.org>]

bbende commented on issue #4170: NIFI-7294 Address deprecation issues in solrj and httpclient
URL: https://github.com/apache/nifi/pull/4170#issuecomment-606110930
 
 
   A couple of things from reviewing...
   
   1) It seems like this branch includes the commits for the previous work on upgrading SolrJ, there should only be one commit in this PR for the new changes for NIFI-7294.
   
   2) I think there is a potential issue with our use of the `HttpClientUtil` static methods... since we set static values in there, once one Solr processor has been created that is configured with Kerberos or SSL, then that static state has been set in `HttpClientUtil `and now if someone made a second Solr processor that wasn't using Kerberos or SSL, that stuff would still be set in `HttpClientUtil`. It looks like there is a method `resetHttpClientBuilder()` that we should call at the beginning of `createSolrClient`, but we also need to ensure we are inside a synchronized block so that two different Solr processors don't alter `HttpClientUtil` at the same time. We can do that by making `createSolrClient` synchronized.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services