You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/08/02 11:02:35 UTC

[GitHub] [camel-website] aashnajena opened a new pull request #445: Fix Search Results

aashnajena opened a new pull request #445:
URL: https://github.com/apache/camel-website/pull/445


   The search results for blogs, articles, books, download are showing up like this:
   
   ![image](https://user-images.githubusercontent.com/32356795/89121497-0a117a80-d4dd-11ea-8275-db5d90ff7742.png)
   
   The expected behaviour is shown below. I've made [PR #2133](https://github.com/algolia/docsearch-configs/pull/2133) on the Algolia repo to fix changes in the config file. With the changes in the config file + changes in this PR, we will be able to achieve the expected behaviour. 
   
   ![image](https://user-images.githubusercontent.com/32356795/89121439-91122300-d4dc-11ea-80f8-6c63a2fa620e.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] zregvart commented on pull request #445: fix: search results

Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #445:
URL: https://github.com/apache/camel-website/pull/445#issuecomment-669146780


   I’ve triggered a rebuild of the website. I’ll need to take a look at the build configuration, doesn’t seem to trigger automatically on changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] zregvart merged pull request #445: fix: search results

Posted by GitBox <gi...@apache.org>.
zregvart merged pull request #445:
URL: https://github.com/apache/camel-website/pull/445


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] aashnajena commented on pull request #445: Fix Search Results

Posted by GitBox <gi...@apache.org>.
aashnajena commented on pull request #445:
URL: https://github.com/apache/camel-website/pull/445#issuecomment-667683824


   We need the Algolia PR to be merged first


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] zregvart commented on pull request #445: Fix Search Results

Posted by GitBox <gi...@apache.org>.
zregvart commented on pull request #445:
URL: https://github.com/apache/camel-website/pull/445#issuecomment-667682471


   Do we need https://github.com/algolia/docsearch-configs/pull/2133 merged before this, or can we merge this first?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] AemieJ commented on pull request #445: fix: search results

Posted by GitBox <gi...@apache.org>.
AemieJ commented on pull request #445:
URL: https://github.com/apache/camel-website/pull/445#issuecomment-668997654


   I checked with the preview even if blogs, downloads, articles show accurately. We certainly don't want this layout for the project documentation, it's confusing. Why is it that in spite of the doc search config being correct and your code corresponding to it is correct, for documentation is a different layout than expected?  
   
   @zregvart is it 'cause the site hasn't been built yet or any other reason?
   ![search-result-now](https://user-images.githubusercontent.com/44139348/89377012-935bc380-d70e-11ea-9537-67167157be31.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-website] aashnajena commented on pull request #445: Fix Search Results

Posted by GitBox <gi...@apache.org>.
aashnajena commented on pull request #445:
URL: https://github.com/apache/camel-website/pull/445#issuecomment-667932244


   This PR can be merged now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org