You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/10 21:40:23 UTC

[GitHub] [incubator-superset] lilykuang opened a new pull request #10178: style: new toast design closer to SIP-34

lilykuang opened a new pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR is still work in process but I'd like to have early feedback. 
   - update Toast style to match SIP-34
   - change `Toast` and `ToastPresenter` to typescript 
   - move `toast.less` to emotion style
   - add Icon and style for error/warning and success toast 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   **Before**
   <img width="1792" alt="before_toast" src="https://user-images.githubusercontent.com/5705598/85901482-d1cc9d00-b7b6-11ea-9d19-beb98086c14e.png">
   **After**
   **Success Toast**
   <img width="1792" alt="after_toast" src="https://user-images.githubusercontent.com/5705598/85901594-050f2c00-b7b7-11ea-9f65-b4db810ec94d.png">
   **Error/Warning Toast**
   <img width="1792" alt="Screen Shot 2020-07-06 at 5 59 53 PM" src="https://user-images.githubusercontent.com/5705598/86679688-a9148680-bfb2-11ea-84b0-50fab9249221.png">
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - toggle ENABLE_REACT_CRUD_VIEWS config flag, see changes in dataset/chart view
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10178: style: [WIP] new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r447368713



##########
File path: superset-frontend/src/messageToasts/components/ToastPresenter.tsx
##########
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import styled from '@superset-ui/style';
+import Toast from './Toast';
+
+const StyledToastPresenter = styled.div`
+  max-width: 600px;
+  position: fixed;
+  bottom: 0px;
+  right: -110px;
+  transform: translate(-50%, 0);
+  z-index: ${({ theme }) => theme.zIndex.max};
+
+  .toast {
+    background: ${({ theme }) => theme.colors.grayscale.dark1};
+    border-radius: ${({ theme }) => theme.borderRadius};
+    box-shadow: 0 2px 4px 0
+      fade(
+        ${({ theme }) => theme.colors.grayscale.dark2},
+        ${({ theme }) => theme.opacity.mediumLight}
+      );
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 0;
+    position: relative;
+    transform: translateY(-100%);
+    white-space: pre-line;
+    will-change: transform, opacity;
+    transition: transform ${({ theme }) => theme.transitionTiming}s,
+      opacity ${({ theme }) => theme.transitionTiming}s;
+
+    &:after {
+      content: '';
+      position: absolute;
+      top: 0;
+      left: 0;
+      width: 6px;
+      height: 100%;
+    }
+  }
+
+  .toast > button {
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 1;
+  }
+
+  .toast--visible {
+    opacity: 1;
+    transform: translateY(0);
+  }
+`;
+
+type ToastType =
+  | 'INFO_TOAST'
+  | 'SUCCESS_TOAST'
+  | 'WARNING_TOAST'
+  | 'DANGER_TOAST';
+
+type ToastShape = {
+  id: string;
+  toastType: ToastType;
+  text: string;
+  duration: number;
+};
+
+interface ToastPresenterProps {
+  toasts: Array<ToastShape>;
+  removeToast: () => void;
+}
+
+const ToastPresenter = ({ toasts, removeToast }: ToastPresenterProps) =>
+  toasts.length > 0 && (
+    <StyledToastPresenter id="toast-presenter">

Review comment:
       Do you think using a [Portal](https://reactjs.org/docs/portals.html) for this might make it easier? 

##########
File path: superset-frontend/package.json
##########
@@ -61,14 +61,14 @@
     "@emotion/core": "^10.0.28",
     "@superset-ui/chart": "^0.14.1",
     "@superset-ui/chart-composition": "^0.14.1",
-    "@superset-ui/color": "^0.14.2",
+    "@superset-ui/chart-controls": "^0.14.1",
+    "@superset-ui/color": "^0.14.1",

Review comment:
       were the downgrades here intentional?

##########
File path: superset-frontend/src/messageToasts/components/Toast.tsx
##########
@@ -31,24 +30,43 @@ import {
   DANGER_TOAST,
 } from '../constants';
 
-const propTypes = {
-  toast: toastShape.isRequired,
-  onCloseToast: PropTypes.func.isRequired,
-};
+const ToastContianer = styled.div`
+  display: flex;
+  justify-content: center;
+  align-items: center;
+
+  span {
+    padding: 0 11px;
+  }
+`;
+
+type ToastType =
+  | 'INFO_TOAST'
+  | 'SUCCESS_TOAST'
+  | 'WARNING_TOAST'
+  | 'DANGER_TOAST';
+
+interface ToastPresenterProps {
+  toast: { id: string; toastType: ToastType; text: string; duration: number };
+  onCloseToast: (arg0: string) => void;

Review comment:
       let's name this argument

##########
File path: superset-frontend/src/messageToasts/components/ToastPresenter.tsx
##########
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import styled from '@superset-ui/style';
+import Toast from './Toast';
+
+const StyledToastPresenter = styled.div`
+  max-width: 600px;
+  position: fixed;
+  bottom: 0px;
+  right: -110px;
+  transform: translate(-50%, 0);
+  z-index: ${({ theme }) => theme.zIndex.max};
+
+  .toast {
+    background: ${({ theme }) => theme.colors.grayscale.dark1};
+    border-radius: ${({ theme }) => theme.borderRadius};
+    box-shadow: 0 2px 4px 0
+      fade(
+        ${({ theme }) => theme.colors.grayscale.dark2},
+        ${({ theme }) => theme.opacity.mediumLight}
+      );
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 0;
+    position: relative;
+    transform: translateY(-100%);
+    white-space: pre-line;
+    will-change: transform, opacity;
+    transition: transform ${({ theme }) => theme.transitionTiming}s,
+      opacity ${({ theme }) => theme.transitionTiming}s;
+
+    &:after {
+      content: '';
+      position: absolute;
+      top: 0;
+      left: 0;
+      width: 6px;
+      height: 100%;
+    }
+  }
+
+  .toast > button {
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 1;
+  }
+
+  .toast--visible {
+    opacity: 1;
+    transform: translateY(0);
+  }
+`;
+
+type ToastType =
+  | 'INFO_TOAST'
+  | 'SUCCESS_TOAST'
+  | 'WARNING_TOAST'
+  | 'DANGER_TOAST';
+
+type ToastShape = {
+  id: string;
+  toastType: ToastType;
+  text: string;
+  duration: number;
+};
+
+interface ToastPresenterProps {
+  toasts: Array<ToastShape>;
+  removeToast: () => void;
+}
+
+const ToastPresenter = ({ toasts, removeToast }: ToastPresenterProps) =>
+  toasts.length > 0 && (
+    <StyledToastPresenter id="toast-presenter">

Review comment:
       Although looking at the diff, it seems like this was written like this before, so up to you if you want to see if a Portal is easier or not




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai merged pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
nytai merged pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#issuecomment-650429564


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=h1) Report
   > Merging [#10178](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8d9bb5f472337df388888f8d034ba11a871cb776&el=desc) will **decrease** coverage by `0.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10178/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10178      +/-   ##
   ==========================================
   - Coverage   70.15%   69.61%   -0.54%     
   ==========================================
     Files         598      194     -404     
     Lines       32004    18862   -13142     
     Branches     3236        0    -3236     
   ==========================================
   - Hits        22451    13131    -9320     
   + Misses       9448     5731    -3717     
   + Partials      105        0     -105     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `69.61% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...ntend/src/dashboard/components/FilterIndicator.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvci5qc3g=) | | |
   | [superset-frontend/src/logger/actions/index.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2xvZ2dlci9hY3Rpb25zL2luZGV4Lmpz) | | |
   | [superset-frontend/src/components/Select/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L3V0aWxzLnRz) | | |
   | [.../src/dashboard/components/DeleteComponentModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0RlbGV0ZUNvbXBvbmVudE1vZGFsLmpzeA==) | | |
   | [...erset-frontend/src/profile/components/UserInfo.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9Vc2VySW5mby5qc3g=) | | |
   | [...frontend/src/dashboard/actions/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL2Rhc2hib2FyZEZpbHRlcnMuanM=) | | |
   | [...et-frontend/src/SqlLab/components/LimitControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC5qc3g=) | | |
   | [...uperset-frontend/src/components/PopoverSection.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUG9wb3ZlclNlY3Rpb24uanN4) | | |
   | [superset-frontend/src/components/Link.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGluay50c3g=) | | |
   | [.../src/explore/components/controls/BoundsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Cb3VuZHNDb250cm9sLmpzeA==) | | |
   | ... and [390 more](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=footer). Last update [8d9bb5f...62da4ba](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r451899304



##########
File path: superset-frontend/images/icons/check.svg
##########
@@ -0,0 +1,22 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+    http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12 2C6.47715 2 2 6.47715 2 12C2 17.5228 6.47715 22 12 22C17.5228 22 22 17.5228 22 12C22 9.34784 20.9464 6.8043 19.0711 4.92893C17.1957 3.05357 14.6522 2 12 2Z" fill="#666666"/>

Review comment:
       [CSS rules end up overriding the property.](https://css-tricks.com/almanac/properties/f/fill/) However, it's best to be consistent and use `currentColor`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] lilykuang commented on a change in pull request #10178: style: [WIP] new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
lilykuang commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r447421371



##########
File path: superset-frontend/package.json
##########
@@ -61,14 +61,14 @@
     "@emotion/core": "^10.0.28",
     "@superset-ui/chart": "^0.14.1",
     "@superset-ui/chart-composition": "^0.14.1",
-    "@superset-ui/color": "^0.14.2",
+    "@superset-ui/chart-controls": "^0.14.1",
+    "@superset-ui/color": "^0.14.1",

Review comment:
       @etr2460  I didn't clean up conflict correctly. All package should be up to date now. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r452490611



##########
File path: superset-frontend/images/icons/check.svg
##########
@@ -0,0 +1,22 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+    http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12 2C6.47715 2 2 6.47715 2 12C2 17.5228 6.47715 22 12 22C17.5228 22 22 17.5228 22 12C22 9.34784 20.9464 6.8043 19.0711 4.92893C17.1957 3.05357 14.6522 2 12 2Z" fill="#666666"/>

Review comment:
       color seems reasonable, as that's how the icon fonts behave. We should def try to use `currentColor` for fill rules when it makes sense as it allows for the most flexibility. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] lilykuang commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
lilykuang commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r451926905



##########
File path: superset-frontend/src/messageToasts/components/Toast.tsx
##########
@@ -97,13 +117,17 @@ class Toast extends React.Component {
           toastType === DANGER_TOAST && 'toast--danger',
         )}
       >
-        <Interweave content={text} />
+        <ToastContianer>
+          {toastType === SUCCESS_TOAST ? (
+            <Icon name="check" />
+          ) : (
+            <Icon name="error" />
+          )}

Review comment:
       I will prefer info toasts without Icon and warning toasts will have the same icon as error.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#issuecomment-650429564


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=h1) Report
   > Merging [#10178](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4965d87505dd9febc50d864d9fe3c7f15d1f50c2&el=desc) will **decrease** coverage by `0.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10178/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10178      +/-   ##
   ==========================================
   - Coverage   70.56%   70.31%   -0.26%     
   ==========================================
     Files         594      190     -404     
     Lines       31474    18369   -13105     
     Branches     3228        0    -3228     
   ==========================================
   - Hits        22211    12916    -9295     
   + Misses       9147     5453    -3694     
   + Partials      116        0     -116     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.31% <ø> (-0.08%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.87% <0.00%> (-0.85%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.72% <0.00%> (-0.26%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-0.15%)` | :arrow_down: |
   | [...perset-frontend/src/dashboard/util/findParentId.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2ZpbmRQYXJlbnRJZC5qcw==) | | |
   | [...perset-frontend/src/dashboard/containers/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0NoYXJ0LmpzeA==) | | |
   | [superset-frontend/src/components/Menu/Menu.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9NZW51LmpzeA==) | | |
   | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | | |
   | [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
   | [...dashboard/components/gridComponents/new/NewRow.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdSb3cuanN4) | | |
   | ... and [394 more](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=footer). Last update [4965d87...4b1bdf6](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#issuecomment-650429564


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=h1) Report
   > Merging [#10178](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8d9bb5f472337df388888f8d034ba11a871cb776&el=desc) will **decrease** coverage by `0.53%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10178/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10178      +/-   ##
   ==========================================
   - Coverage   70.15%   69.61%   -0.54%     
   ==========================================
     Files         598      194     -404     
     Lines       32004    18862   -13142     
     Branches     3236        0    -3236     
   ==========================================
   - Hits        22451    13131    -9320     
   + Misses       9448     5731    -3717     
   + Partials      105        0     -105     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `69.61% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | | |
   | [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | | |
   | [superset-frontend/src/components/VictoryTheme.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVmljdG9yeVRoZW1lLmpz) | | |
   | [...hboard/components/filterscope/FilterScopeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlclNjb3BlTW9kYWwuanN4) | | |
   | [...ponents/filterscope/renderFilterScopeTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlclNjb3BlVHJlZU5vZGVzLmpzeA==) | | |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | | |
   | [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | | |
   | [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | | |
   | [...hboard/components/gridComponents/new/NewHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL25ldy9OZXdIZWFkZXIuanN4) | | |
   | [...rontend/src/visualizations/TimeTable/TimeTable.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL1RpbWVUYWJsZS9UaW1lVGFibGUuanN4) | | |
   | ... and [390 more](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=footer). Last update [8d9bb5f...62da4ba](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r451924161



##########
File path: superset-frontend/images/icons/check.svg
##########
@@ -0,0 +1,22 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+    http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12 2C6.47715 2 2 6.47715 2 12C2 17.5228 6.47715 22 12 22C17.5228 22 22 17.5228 22 12C22 9.34784 20.9464 6.8043 19.0711 4.92893C17.1957 3.05357 14.6522 2 12 2Z" fill="#666666"/>

Review comment:
       ah, I see. I was using `color` to change the icon's color and not `fill` so it didn't work. Do we prefer to override this with `color` or `fill` on the icon? i was planning a change to the Icon component to get rid of `styled` and use this method instead; with this then `color` works:
   ```typescript
   const Icon = ({ name, color = '#666666', ...rest }: IconProps) => {
     const Component = iconsRegistry[name];
     return <Component color={color} {...rest} />;
   };
   
   export default Icon;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] lilykuang commented on a change in pull request #10178: style: [WIP] new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
lilykuang commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r450530375



##########
File path: superset-frontend/src/messageToasts/components/ToastPresenter.tsx
##########
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import styled from '@superset-ui/style';
+import Toast from './Toast';
+
+const StyledToastPresenter = styled.div`
+  max-width: 600px;
+  position: fixed;
+  bottom: 0px;
+  right: -110px;
+  transform: translate(-50%, 0);
+  z-index: ${({ theme }) => theme.zIndex.max};
+
+  .toast {
+    background: ${({ theme }) => theme.colors.grayscale.dark1};
+    border-radius: ${({ theme }) => theme.borderRadius};
+    box-shadow: 0 2px 4px 0
+      fade(
+        ${({ theme }) => theme.colors.grayscale.dark2},
+        ${({ theme }) => theme.opacity.mediumLight}
+      );
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 0;
+    position: relative;
+    transform: translateY(-100%);
+    white-space: pre-line;
+    will-change: transform, opacity;
+    transition: transform ${({ theme }) => theme.transitionTiming}s,
+      opacity ${({ theme }) => theme.transitionTiming}s;
+
+    &:after {
+      content: '';
+      position: absolute;
+      top: 0;
+      left: 0;
+      width: 6px;
+      height: 100%;
+    }
+  }
+
+  .toast > button {
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 1;
+  }
+
+  .toast--visible {
+    opacity: 1;
+    transform: translateY(0);
+  }
+`;
+
+type ToastType =
+  | 'INFO_TOAST'
+  | 'SUCCESS_TOAST'
+  | 'WARNING_TOAST'
+  | 'DANGER_TOAST';
+
+type ToastShape = {
+  id: string;
+  toastType: ToastType;
+  text: string;
+  duration: number;
+};
+
+interface ToastPresenterProps {
+  toasts: Array<ToastShape>;
+  removeToast: () => void;
+}
+
+const ToastPresenter = ({ toasts, removeToast }: ToastPresenterProps) =>
+  toasts.length > 0 && (
+    <StyledToastPresenter id="toast-presenter">

Review comment:
       I think I will keep this way




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r450613610



##########
File path: superset-frontend/src/messageToasts/components/Toast.tsx
##########
@@ -97,13 +117,17 @@ class Toast extends React.Component {
           toastType === DANGER_TOAST && 'toast--danger',
         )}
       >
-        <Interweave content={text} />
+        <ToastContianer>
+          {toastType === SUCCESS_TOAST ? (
+            <Icon name="check" />
+          ) : (
+            <Icon name="error" />
+          )}

Review comment:
       Since we have a warning icon, should we use that for the `WARNING_TOAST`s too? And perhaps add an info icon as well? If we don't add the info icon, should we perhaps default to no icon at all, since it could be confusing for an info toast to show an error icon

##########
File path: superset-frontend/src/messageToasts/components/Toast.tsx
##########
@@ -97,13 +117,17 @@ class Toast extends React.Component {
           toastType === DANGER_TOAST && 'toast--danger',

Review comment:
       Are these classes still needed? It looks like they're unused now

##########
File path: superset-frontend/src/messageToasts/components/ToastPresenter.tsx
##########
@@ -0,0 +1,96 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import styled from '@superset-ui/style';
+import Toast from './Toast';
+
+const StyledToastPresenter = styled.div`
+  max-width: 600px;
+  position: fixed;
+  bottom: 0px;
+  right: -110px;
+  transform: translate(-50%, 0);
+  z-index: ${({ theme }) => theme.zIndex.max};
+
+  .toast {
+    background: ${({ theme }) => theme.colors.grayscale.dark1};
+    border-radius: ${({ theme }) => theme.borderRadius};
+    box-shadow: 0 2px 4px 0
+      fade(
+        ${({ theme }) => theme.colors.grayscale.dark2},
+        ${({ theme }) => theme.opacity.mediumLight}
+      );
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 0;
+    position: relative;
+    transform: translateY(-100%);
+    white-space: pre-line;
+    will-change: transform, opacity;
+    transition: transform ${({ theme }) => theme.transitionTiming}s,
+      opacity ${({ theme }) => theme.transitionTiming}s;
+
+    &:after {
+      content: '';
+      position: absolute;
+      top: 0;
+      left: 0;
+      width: 6px;
+      height: 100%;
+    }
+  }
+
+  .toast > button {
+    color: ${({ theme }) => theme.colors.grayscale.light5};
+    opacity: 1;
+  }
+
+  .toast--visible {
+    opacity: 1;
+    transform: translateY(0);
+  }
+`;
+
+type ToastType =

Review comment:
       this is defined twice, let's pull it into a `types.ts` file




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#issuecomment-650429564


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=h1) Report
   > Merging [#10178](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8d9bb5f472337df388888f8d034ba11a871cb776&el=desc) will **decrease** coverage by `0.46%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10178/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10178      +/-   ##
   ==========================================
   - Coverage   70.15%   69.68%   -0.47%     
   ==========================================
     Files         598      194     -404     
     Lines       32004    18862   -13142     
     Branches     3236        0    -3236     
   ==========================================
   - Hits        22451    13144    -9307     
   + Misses       9448     5718    -3730     
   + Partials      105        0     -105     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `69.68% <ø> (+0.06%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | | |
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | | |
   | [...hboard/components/menu/BackgroundStyleDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL21lbnUvQmFja2dyb3VuZFN0eWxlRHJvcGRvd24uanN4) | | |
   | [...nd/src/dashboard/components/ColorComponentPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0NvbG9yQ29tcG9uZW50UGFuZS5qc3g=) | | |
   | [superset-frontend/src/SqlLab/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb25zdGFudHMuanM=) | | |
   | [superset-frontend/src/components/Loading.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTG9hZGluZy50c3g=) | | |
   | [...dashboard/components/FilterIndicatorsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvcnNDb250YWluZXIuanN4) | | |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=) | | |
   | [...shboard/components/filterscope/FilterFieldItem.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL0ZpbHRlckZpZWxkSXRlbS5qc3g=) | | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=) | | |
   | ... and [394 more](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=footer). Last update [8d9bb5f...62da4ba](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] nytai commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
nytai commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r446435061



##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -145,8 +145,11 @@ function SelectFilter({
           data-test="filters-select"
           themeConfig={filterSelectTheme}
           stylesConfig={filterSelectStyles}
+          // @ts-ignore

Review comment:
       It seems I introduced these issues when I added https://github.com/vtaits/react-select-async-paginate in https://github.com/apache/incubator-superset/pull/10035 and this PR merely uncovered them (for some reason... 🤔). I'll address in another PR if it's possible, the types for that package are quite confusing. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#issuecomment-650429564


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=h1) Report
   > Merging [#10178](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4965d87505dd9febc50d864d9fe3c7f15d1f50c2&el=desc) will **decrease** coverage by `0.25%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10178/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10178      +/-   ##
   ==========================================
   - Coverage   70.56%   70.31%   -0.26%     
   ==========================================
     Files         594      190     -404     
     Lines       31474    18369   -13105     
     Branches     3228        0    -3228     
   ==========================================
   - Hits        22211    12916    -9295     
   + Misses       9147     5453    -3694     
   + Partials      116        0     -116     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.31% <ø> (-0.08%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.72% <0.00%> (-12.77%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.87% <0.00%> (-0.85%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.72% <0.00%> (-0.26%)` | :arrow_down: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.10% <0.00%> (-0.15%)` | :arrow_down: |
   | [...ontend/src/dashboard/components/dnd/DragHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9EcmFnSGFuZGxlLmpzeA==) | | |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | | |
   | [...explore/components/controls/ColorSchemeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclNjaGVtZUNvbnRyb2wuanN4) | | |
   | [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | | |
   | [...tend/src/dashboard/util/getFilterFieldNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlckZpZWxkTm9kZXNUcmVlLmpz) | | |
   | [...nd/src/messageToasts/containers/ToastPresenter.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL21lc3NhZ2VUb2FzdHMvY29udGFpbmVycy9Ub2FzdFByZXNlbnRlci5qc3g=) | | |
   | ... and [394 more](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=footer). Last update [4965d87...4b1bdf6](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r451924161



##########
File path: superset-frontend/images/icons/check.svg
##########
@@ -0,0 +1,22 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+    http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12 2C6.47715 2 2 6.47715 2 12C2 17.5228 6.47715 22 12 22C17.5228 22 22 17.5228 22 12C22 9.34784 20.9464 6.8043 19.0711 4.92893C17.1957 3.05357 14.6522 2 12 2Z" fill="#666666"/>

Review comment:
       ah, I see. I was using `color` to change the icon's color and not `fill` so it didn't work. Do we prefer to override this with `color` or `fill` on the icon? i was planning a change to the Icon component to get rid of `styled` and use this method instead; with this then `color` works:
   ```
   const Icon = ({ name, color = '#666666', ...rest }: IconProps) => {
     const Component = iconsRegistry[name];
     return <Component color={color} {...rest} />;
   };
   
   export default Icon;
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#issuecomment-654605350


   one more design nit, not sure if it's worth fixing though... It seems like the `x` isn't vertically centered in the toast. It's easier to see when enlarged: 
   ![image](https://user-images.githubusercontent.com/7409244/86716144-c444bd80-bfd5-11ea-8246-e4f412c14b49.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#issuecomment-650429564


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=h1) Report
   > Merging [#10178](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/4965d87505dd9febc50d864d9fe3c7f15d1f50c2&el=desc) will **decrease** coverage by `0.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10178/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10178      +/-   ##
   ==========================================
   - Coverage   70.56%   70.38%   -0.19%     
   ==========================================
     Files         594      190     -404     
     Lines       31474    18369   -13105     
     Branches     3228        0    -3228     
   ==========================================
   - Hits        22211    12929    -9282     
   + Misses       9147     5440    -3707     
   + Partials      116        0     -116     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `70.38% <ø> (ø)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | | |
   | [...t-frontend/src/dashboard/components/SliceAdder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlQWRkZXIuanN4) | | |
   | [...ontend/src/explore/components/QueryAndSaveBtns.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9RdWVyeUFuZFNhdmVCdG5zLmpzeA==) | | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
   | [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | | |
   | [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | | |
   | [...rset-frontend/src/profile/components/Favorites.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvY29tcG9uZW50cy9GYXZvcml0ZXMuanN4) | | |
   | [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz) | | |
   | [...ponents/filterscope/renderFilterFieldTreeNodes.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3JlbmRlckZpbHRlckZpZWxkVHJlZU5vZGVzLmpzeA==) | | |
   | ... and [390 more](https://codecov.io/gh/apache/incubator-superset/pull/10178/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=footer). Last update [4965d87...4b1bdf6](https://codecov.io/gh/apache/incubator-superset/pull/10178?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r451011436



##########
File path: superset-frontend/images/icons/check.svg
##########
@@ -0,0 +1,22 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+ 
+    http://www.apache.org/licenses/LICENSE-2.0
+ 
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M12 2C6.47715 2 2 6.47715 2 12C2 17.5228 6.47715 22 12 22C17.5228 22 22 17.5228 22 12C22 9.34784 20.9464 6.8043 19.0711 4.92893C17.1957 3.05357 14.6522 2 12 2Z" fill="#666666"/>

Review comment:
       One more comment, I think you might need to default the `fill` attribute to `"currentColor"` so that we can override the color of the icon with CSS




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] lilykuang closed pull request #10178: style: new toast design closer to SIP-34

Posted by GitBox <gi...@apache.org>.
lilykuang closed pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org