You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/24 13:58:55 UTC
[GitHub] [flink] lirui-apache opened a new pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
lirui-apache opened a new pull request #14203:
URL: https://github.com/apache/flink/pull/14203
…ing on JM/TM
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
When hive deps are missing on JM/TM, users get exception messages like:
```
CorruptConfigurationException: Could not read the user code wrapper: invalid type code: 18
```
This PR is to avoid corrupting the object output stream, so that we instead get exceptions like:
```
ClassNotFoundException: org.apache.flink.connectors.hive.HiveSource
```
## Brief change log
- Use separate SerDe for `JobConf` and `StorageDescriptor` in `JobConfWrapper` and `HiveTablePartition`.
- Update `HiveTableInputFormat` to use `JobConfWrapper`.
## Verifying this change
Existing tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: yes
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? NA
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
}, {
"hash" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119",
"triggerID" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a13e6fad741657a2648939302d46e79fda78579 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092)
* c2903c4e6b43d289779189bac248e1a380df297d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099)
* acc52ec8bdb70d2b5e964692f9d12136f9573822 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
StephanEwen edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-733673544
The change to `JobConfWrapper` looks good.
For the `SerializableWrapper` - have you considered reusing `SerializedValue`
It is a similar, but serializes eagerly and deserializes lazily, which has a few advantages:
- It makes it easier to supply a custom classloader when needed
- Exceptions occur in the code that writes/access the value, not in the JavaSerialization stack. That is much easier to understand for users and to debug for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56767b51e737eded08cb9609d2b2bc23696f71e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069)
* 8a5b5dee2f9b85f859fff384cb31f33b4ed3902c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084)
* 9a13e6fad741657a2648939302d46e79fda78579 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732991473
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b798d9903dba6ede82cbbbef7956289935b598c7 (Tue Nov 24 14:01:15 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b798d9903dba6ede82cbbbef7956289935b598c7 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
}, {
"hash" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119",
"triggerID" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c2903c4e6b43d289779189bac248e1a380df297d Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099)
* acc52ec8bdb70d2b5e964692f9d12136f9573822 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #14203:
URL: https://github.com/apache/flink/pull/14203
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
}, {
"hash" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119",
"triggerID" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acc52ec8bdb70d2b5e964692f9d12136f9573822 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a13e6fad741657a2648939302d46e79fda78579 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092)
* c2903c4e6b43d289779189bac248e1a380df297d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
}, {
"hash" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119",
"triggerID" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"triggerType" : "PUSH"
}, {
"hash" : "d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10170",
"triggerID" : "d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acc52ec8bdb70d2b5e964692f9d12136f9573822 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119)
* d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10170)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b798d9903dba6ede82cbbbef7956289935b598c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048)
* 56767b51e737eded08cb9609d2b2bc23696f71e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069)
* 8a5b5dee2f9b85f859fff384cb31f33b4ed3902c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-733690915
@StephanEwen Thanks for reviewing. I wasn't aware of `SerializedValue`. And yes I think we should reuse it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a13e6fad741657a2648939302d46e79fda78579 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-734177915
Can we put the caching logic into a `CachedSerializedValue`?
I am afraid that changing the `SerializedValue` can break existing code which relies on the fact that a new copy of the object is created on de-serialization.
Otherwise this looks good to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 56767b51e737eded08cb9609d2b2bc23696f71e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069)
* 8a5b5dee2f9b85f859fff384cb31f33b4ed3902c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
}, {
"hash" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119",
"triggerID" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"triggerType" : "PUSH"
}, {
"hash" : "d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* acc52ec8bdb70d2b5e964692f9d12136f9573822 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119)
* d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b798d9903dba6ede82cbbbef7956289935b598c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048)
* 56767b51e737eded08cb9609d2b2bc23696f71e6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-734138103
@StephanEwen @JingsongLi Would you mind have a look at the PR? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-734325787
Thanks!
Looks good, +1 from my side!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] StephanEwen commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
StephanEwen commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-733673544
The change to `JobConfWrapper` looks good.
For the `SerializableWrapper` - have you considered reusing `SerializedValue` ? It is a similar, only that it lazily deserialized, which makes it easier to supply a custom classloader when needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b798d9903dba6ede82cbbbef7956289935b598c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a13e6fad741657a2648939302d46e79fda78579 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092)
* c2903c4e6b43d289779189bac248e1a380df297d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b798d9903dba6ede82cbbbef7956289935b598c7 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-733922062
Side note: I filed a ticket for the unrelated test failure: https://issues.apache.org/jira/browse/FLINK-20360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
}, {
"hash" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9a13e6fad741657a2648939302d46e79fda78579 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092)
* c2903c4e6b43d289779189bac248e1a380df297d Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099)
* acc52ec8bdb70d2b5e964692f9d12136f9573822 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-734227347
Hi @StephanEwen , I have reverted the changes to `SerializedValue` and added `CachedSerializedValue` instead. Please have another look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
}, {
"hash" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10084",
"triggerID" : "8a5b5dee2f9b85f859fff384cb31f33b4ed3902c",
"triggerType" : "PUSH"
}, {
"hash" : "9a13e6fad741657a2648939302d46e79fda78579",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10092",
"triggerID" : "9a13e6fad741657a2648939302d46e79fda78579",
"triggerType" : "PUSH"
}, {
"hash" : "c2903c4e6b43d289779189bac248e1a380df297d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10099",
"triggerID" : "c2903c4e6b43d289779189bac248e1a380df297d",
"triggerType" : "PUSH"
}, {
"hash" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10119",
"triggerID" : "acc52ec8bdb70d2b5e964692f9d12136f9573822",
"triggerType" : "PUSH"
}, {
"hash" : "d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10170",
"triggerID" : "d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d7e9a60e8d3dc2edc6d99dcd8e3c32a24d7787ed Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10170)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] lirui-apache commented on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
lirui-apache commented on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-733709249
I made `SerializedValue` cache the deserialized value so that we don't deserialize repeatedly. I hope that's OK, otherwise I can do that in the hive classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14203: [FLINK-20241][hive] Improve exception message when hive deps are miss…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14203:
URL: https://github.com/apache/flink/pull/14203#issuecomment-732998162
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048",
"triggerID" : "b798d9903dba6ede82cbbbef7956289935b598c7",
"triggerType" : "PUSH"
}, {
"hash" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069",
"triggerID" : "56767b51e737eded08cb9609d2b2bc23696f71e6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b798d9903dba6ede82cbbbef7956289935b598c7 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10048)
* 56767b51e737eded08cb9609d2b2bc23696f71e6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10069)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org