You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/02/07 18:59:09 UTC
Review Request 65549: Improved some default executor log messages.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65549/
-----------------------------------------------------------
Review request for mesos, Greg Mann, Qian Zhang, and Vinod Kone.
Bugs: MESOS-8468
https://issues.apache.org/jira/browse/MESOS-8468
Repository: mesos
Description
-------
Improved some default executor log messages.
Diffs
-----
src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65549/diff/1/
Testing
-------
None, this patch doesn't contain functional changes.
Thanks,
Gaston Kleiman
Re: Review Request 65549: Improved some default executor log messages.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
> On Feb. 9, 2018, 6:06 p.m., Joseph Wu wrote:
> > Harmless enough. What's the reason behind wanting to `s/launch/launch group/` ?
I wanted to clearly differentiate between launching groups, tasks, and children containers (this executor does it all).
- Gaston
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65549/#review197215
-----------------------------------------------------------
On Feb. 7, 2018, 10:59 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65549/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 10:59 a.m.)
>
>
> Review request for mesos, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8468
> https://issues.apache.org/jira/browse/MESOS-8468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved some default executor log messages.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65549/diff/1/
>
>
> Testing
> -------
>
> None, this patch doesn't contain functional changes.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65549: Improved some default executor log messages.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65549/#review197215
-----------------------------------------------------------
Harmless enough. What's the reason behind wanting to `s/launch/launch group/` ?
src/launcher/default_executor.cpp
Line 509 (original), 509 (patched)
<https://reviews.apache.org/r/65549/#comment277351>
What about this one?
- Joseph Wu
On Feb. 7, 2018, 10:59 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65549/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 10:59 a.m.)
>
>
> Review request for mesos, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8468
> https://issues.apache.org/jira/browse/MESOS-8468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved some default executor log messages.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65549/diff/1/
>
>
> Testing
> -------
>
> None, this patch doesn't contain functional changes.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65549: Improved some default executor log messages.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65549/#review197258
-----------------------------------------------------------
Ship it!
Ship It!
- Qian Zhang
On Feb. 10, 2018, 2:34 p.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65549/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2018, 2:34 p.m.)
>
>
> Review request for mesos, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8468
> https://issues.apache.org/jira/browse/MESOS-8468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved some default executor log messages.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65549/diff/2/
>
>
> Testing
> -------
>
> None, this patch doesn't contain functional changes.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65549: Improved some default executor log messages.
Posted by Vinod Kone <vi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65549/#review197302
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 10, 2018, 6:34 a.m., Gaston Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65549/
> -----------------------------------------------------------
>
> (Updated Feb. 10, 2018, 6:34 a.m.)
>
>
> Review request for mesos, Greg Mann, Qian Zhang, and Vinod Kone.
>
>
> Bugs: MESOS-8468
> https://issues.apache.org/jira/browse/MESOS-8468
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Improved some default executor log messages.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
>
>
> Diff: https://reviews.apache.org/r/65549/diff/2/
>
>
> Testing
> -------
>
> None, this patch doesn't contain functional changes.
>
>
> Thanks,
>
> Gaston Kleiman
>
>
Re: Review Request 65549: Improved some default executor log messages.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65549/
-----------------------------------------------------------
(Updated Feb. 9, 2018, 10:34 p.m.)
Review request for mesos, Greg Mann, Qian Zhang, and Vinod Kone.
Changes
-------
Addressed comment.
Bugs: MESOS-8468
https://issues.apache.org/jira/browse/MESOS-8468
Repository: mesos
Description
-------
Improved some default executor log messages.
Diffs (updated)
-----
src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea
Diff: https://reviews.apache.org/r/65549/diff/2/
Changes: https://reviews.apache.org/r/65549/diff/1-2/
Testing
-------
None, this patch doesn't contain functional changes.
Thanks,
Gaston Kleiman