You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/11 19:05:08 UTC

[GitHub] [airflow] dstandish opened a new pull request #20818: Test util `env_vars` to take arbitrary env vars

dstandish opened a new pull request #20818:
URL: https://github.com/apache/airflow/pull/20818


   Currently it assumes that you will only use this for config settings (which you can already do with `conf_vars`).
   
   We should allow any kind of env var so that for example it could be used to patch an airflow conn or any other env var (which is sort of what is advertised in the function name anyway).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #20818: Test util `env_vars` to take arbitrary env vars

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #20818:
URL: https://github.com/apache/airflow/pull/20818


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dstandish edited a comment on pull request #20818: Test util `env_vars` to take arbitrary env vars

Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on pull request #20818:
URL: https://github.com/apache/airflow/pull/20818#issuecomment-1010359648


   @potiuk this one is hanging
   
   > Build Images / Please rebase or amend, and force push the PR to run full tests 
   
   is it ok to merge?  or you think it needs a rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dstandish commented on pull request #20818: Test util `env_vars` to take arbitrary env vars

Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #20818:
URL: https://github.com/apache/airflow/pull/20818#issuecomment-1010359648


   @potiuk this one is hanging
   
   > Build Images / Please rebase or amend, and force push the PR to run full tests 
   
   is it ok to merge?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #20818: Test util `env_vars` to take arbitrary env vars

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20818:
URL: https://github.com/apache/airflow/pull/20818#issuecomment-1010304215


   The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org