[GitHub] [incubator-pinot] npawar commented on a change in pull request #4095: Add additional 30s wait before checking realtime table to account for delays see during realtime table setup

[GitBox <gi...@apache.org>]

npawar commented on a change in pull request #4095: Add additional 30s wait before checking realtime table to account for delays see during realtime table setup
URL: https://github.com/apache/incubator-pinot/pull/4095#discussion_r273761596
 
 

 ##########
 File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/controller/periodic/tasks/SegmentStatusCheckerIntegrationTest.java
 ##########
 @@ -243,6 +243,16 @@ public void testSegmentStatusChecker() {
     Assert.assertEquals(
         controllerMetrics.getValueOfTableGauge(errorOfflineTable, ControllerGauge.PERCENT_SEGMENTS_AVAILABLE), 100);
 
+    // additional 30 seconds wait, to ensure realtime table setup has also completed
 
 Review comment:
   By conditional, do you mean not have the 30 seconds timeout at all? Or take a different path and not do the tests if 30s is up?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org