You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "wombatu-kun (via GitHub)" <gi...@apache.org> on 2024/02/27 13:16:32 UTC
[PR] [HUDI-7396][DOCS] added write.insert.cluster to FlinkOptions [hudi]
wombatu-kun opened a new pull request, #10769:
URL: https://github.com/apache/hudi/pull/10769
### Change Logs
[DOCS] Added config property write.insert.cluster to FlinkOptions
### Impact
none
### Risk level (write none, low medium or high below)
none
### Documentation Update
_Describe any necessary documentation update if there is any new feature, config, or user-facing change_
- _The config description must be updated if new configs are added or the default value of the configs are changed_
- _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
changes to the website._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7396][DOCS] added write.insert.cluster to FlinkOptions [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10769:
URL: https://github.com/apache/hudi/pull/10769#discussion_r1510224117
##########
website/docs/configurations.md:
##########
@@ -228,6 +228,7 @@ Flink jobs using the SQL can be configured through the options in WITH clause. T
| [clustering.async.enabled](#clusteringasyncenabled) | false | Async Clustering, default false<br /> `Config Param: CLUSTERING_ASYNC_ENABLED` |
| [clustering.plan.strategy.small.file.limit](#clusteringplanstrategysmallfilelimit) | 600 | Files smaller than the size specified here are candidates for clustering, default 600 MB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT` |
| [clustering.plan.strategy.target.file.max.bytes](#clusteringplanstrategytargetfilemaxbytes) | 1073741824 | Each group can produce 'N' (CLUSTERING_MAX_GROUP_SIZE/CLUSTERING_TARGET_FILE_SIZE) output file groups, default 1 GB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES` |
+| [write.insert.cluster](#writeinsertcluster) | false | Inline Clustering, that means it will do the clustering on each write, so the write throughput is low comparing to the async clustering. Default false<br /> `Config Param: INSERT_CLUSTER` |
Review Comment:
This config is not missing (https://hudi.apache.org/docs/configurations#Flink-Options-advanced-configs), so i close this PR.
##########
website/docs/configurations.md:
##########
@@ -228,6 +228,7 @@ Flink jobs using the SQL can be configured through the options in WITH clause. T
| [clustering.async.enabled](#clusteringasyncenabled) | false | Async Clustering, default false<br /> `Config Param: CLUSTERING_ASYNC_ENABLED` |
| [clustering.plan.strategy.small.file.limit](#clusteringplanstrategysmallfilelimit) | 600 | Files smaller than the size specified here are candidates for clustering, default 600 MB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT` |
| [clustering.plan.strategy.target.file.max.bytes](#clusteringplanstrategytargetfilemaxbytes) | 1073741824 | Each group can produce 'N' (CLUSTERING_MAX_GROUP_SIZE/CLUSTERING_TARGET_FILE_SIZE) output file groups, default 1 GB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES` |
+| [write.insert.cluster](#writeinsertcluster) | false | Inline Clustering, that means it will do the clustering on each write, so the write throughput is low comparing to the async clustering. Default false<br /> `Config Param: INSERT_CLUSTER` |
Review Comment:
This config is not missing (https://hudi.apache.org/docs/configurations#Flink-Options-advanced-configs), so i close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7396][DOCS] added write.insert.cluster to FlinkOptions [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10769:
URL: https://github.com/apache/hudi/pull/10769#discussion_r1510224125
##########
website/docs/configurations.md:
##########
@@ -228,6 +228,7 @@ Flink jobs using the SQL can be configured through the options in WITH clause. T
| [clustering.async.enabled](#clusteringasyncenabled) | false | Async Clustering, default false<br /> `Config Param: CLUSTERING_ASYNC_ENABLED` |
| [clustering.plan.strategy.small.file.limit](#clusteringplanstrategysmallfilelimit) | 600 | Files smaller than the size specified here are candidates for clustering, default 600 MB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT` |
| [clustering.plan.strategy.target.file.max.bytes](#clusteringplanstrategytargetfilemaxbytes) | 1073741824 | Each group can produce 'N' (CLUSTERING_MAX_GROUP_SIZE/CLUSTERING_TARGET_FILE_SIZE) output file groups, default 1 GB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES` |
+| [write.insert.cluster](#writeinsertcluster) | false | Inline Clustering, that means it will do the clustering on each write, so the write throughput is low comparing to the async clustering. Default false<br /> `Config Param: INSERT_CLUSTER` |
Review Comment:
This config is not missing (https://hudi.apache.org/docs/configurations#Flink-Options-advanced-configs), so i close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7396][DOCS] added write.insert.cluster to FlinkOptions [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun closed pull request #10769: [HUDI-7396][DOCS] added write.insert.cluster to FlinkOptions
URL: https://github.com/apache/hudi/pull/10769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7396][DOCS] added write.insert.cluster to FlinkOptions [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on code in PR #10769:
URL: https://github.com/apache/hudi/pull/10769#discussion_r1504874303
##########
website/docs/configurations.md:
##########
@@ -228,6 +228,7 @@ Flink jobs using the SQL can be configured through the options in WITH clause. T
| [clustering.async.enabled](#clusteringasyncenabled) | false | Async Clustering, default false<br /> `Config Param: CLUSTERING_ASYNC_ENABLED` |
| [clustering.plan.strategy.small.file.limit](#clusteringplanstrategysmallfilelimit) | 600 | Files smaller than the size specified here are candidates for clustering, default 600 MB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT` |
| [clustering.plan.strategy.target.file.max.bytes](#clusteringplanstrategytargetfilemaxbytes) | 1073741824 | Each group can produce 'N' (CLUSTERING_MAX_GROUP_SIZE/CLUSTERING_TARGET_FILE_SIZE) output file groups, default 1 GB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES` |
+| [write.insert.cluster](#writeinsertcluster) | false | Inline Clustering, that means it will do the clustering on each write, so the write throughput is low comparing to the async clustering. Default false<br /> `Config Param: INSERT_CLUSTER` |
Review Comment:
Is this auto-generated? Configuration docs are automatically updated by `generate_config.sh` script: https://github.com/apache/hudi/tree/asf-site/hudi-utils. If you see some configs are missing in the latest docs, you may rerun the script and post the updated `.md` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7396][DOCS] added write.insert.cluster to FlinkOptions [hudi]
Posted by "wombatu-kun (via GitHub)" <gi...@apache.org>.
wombatu-kun commented on code in PR #10769:
URL: https://github.com/apache/hudi/pull/10769#discussion_r1505242448
##########
website/docs/configurations.md:
##########
@@ -228,6 +228,7 @@ Flink jobs using the SQL can be configured through the options in WITH clause. T
| [clustering.async.enabled](#clusteringasyncenabled) | false | Async Clustering, default false<br /> `Config Param: CLUSTERING_ASYNC_ENABLED` |
| [clustering.plan.strategy.small.file.limit](#clusteringplanstrategysmallfilelimit) | 600 | Files smaller than the size specified here are candidates for clustering, default 600 MB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_SMALL_FILE_LIMIT` |
| [clustering.plan.strategy.target.file.max.bytes](#clusteringplanstrategytargetfilemaxbytes) | 1073741824 | Each group can produce 'N' (CLUSTERING_MAX_GROUP_SIZE/CLUSTERING_TARGET_FILE_SIZE) output file groups, default 1 GB<br /> `Config Param: CLUSTERING_PLAN_STRATEGY_TARGET_FILE_MAX_BYTES` |
+| [write.insert.cluster](#writeinsertcluster) | false | Inline Clustering, that means it will do the clustering on each write, so the write throughput is low comparing to the async clustering. Default false<br /> `Config Param: INSERT_CLUSTER` |
Review Comment:
No, it's not. Ok, i'll fix it by generate_config.sh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org