You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/06/29 02:42:42 UTC
[GitHub] [incubator-iotdb] mychaow opened a new pull request #1431: change the way to get MManager
mychaow opened a new pull request #1431:
URL: https://github.com/apache/incubator-iotdb/pull/1431
for cluster version could use different MManager
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1431: change the way to get MManager
Posted by GitBox <gi...@apache.org>.
SilverNarcissus commented on a change in pull request #1431:
URL: https://github.com/apache/incubator-iotdb/pull/1431#discussion_r446824094
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -178,6 +178,10 @@ public synchronized void removeItem(String key) {
MTREE_SNAPSHOT_THREAD_CHECK_TIME, TimeUnit.SECONDS);
}
+ /**
+ * we should not use this function in other place,
Review comment:
Other place is where? May be you miss something after ','
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1431: change the way to get MManager
Posted by GitBox <gi...@apache.org>.
mychaow commented on a change in pull request #1431:
URL: https://github.com/apache/incubator-iotdb/pull/1431#discussion_r446833512
##########
File path: server/src/main/java/org/apache/iotdb/db/metadata/MManager.java
##########
@@ -178,6 +178,10 @@ public synchronized void removeItem(String key) {
MTREE_SNAPSHOT_THREAD_CHECK_TIME, TimeUnit.SECONDS);
}
+ /**
+ * we should not use this function in other place,
Review comment:
yes, I will add the comments
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SilverNarcissus commented on pull request #1431: change the way to get MManager
Posted by GitBox <gi...@apache.org>.
SilverNarcissus commented on pull request #1431:
URL: https://github.com/apache/incubator-iotdb/pull/1431#issuecomment-652131645
Fantastic work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] SilverNarcissus merged pull request #1431: change the way to get MManager
Posted by GitBox <gi...@apache.org>.
SilverNarcissus merged pull request #1431:
URL: https://github.com/apache/incubator-iotdb/pull/1431
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org