You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/18 23:06:45 UTC

[GitHub] [pulsar-helm-chart] michaeljmarshall commented on a diff in pull request #225: allow specifying the nodeSelector for the init jobs

michaeljmarshall commented on code in PR #225:
URL: https://github.com/apache/pulsar-helm-chart/pull/225#discussion_r998786444


##########
charts/pulsar/values.yaml:
##########
@@ -652,6 +652,9 @@ pulsar_metadata:
   # configurationStore:
   configurationStoreMetadataPrefix: ""
   configurationStorePort: 2181
+  ## optional you can specify a nodeSelector for all init jobs (pulsar-init & bookkeeper-init)
+  # nodeSelector:
+    # cloud.google.com/gke-nodepool: default-pool

Review Comment:
   Nit: I think it is valuable to add the key to the values file.
   
   ```suggestion
     nodeSelector: {}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org